linux-kernel - Re: [PATCH v4] net/can/gs_usb: increase max interface to U8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41fb9334-5778-4fc6-bfdd-be4778a4b883@coelacanthus.name>
Date: Tue, 30 Sep 2025 19:36:29 +0800
From: Celeste Liu <uwu@...lacanthus.name>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 Maximilian Schneider <max@...neidersoft.net>,
 Henrik Brix Andersen <henrik@...xandersen.dk>,
 Wolfgang Grandegger <wg@...ndegger.com>, Kees Cook <kees@...nel.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>, linux-can@...r.kernel.org,
 linux-kernel@...r.kernel.org, Runcheng Lu <runcheng.lu@...icro.com>,
 stable@...r.kernel.org, Vincent Mailhol <mailhol@...nel.org>
Subject: Re: [PATCH v4] net/can/gs_usb: increase max interface to U8_MAX

On 2025-09-30 16:13, Marc Kleine-Budde wrote:
> On 30.09.2025 14:15:47, Celeste Liu wrote:
>> This issue was found by Runcheng Lu when develop HSCanT USB to CAN FD
>> converter[1]. The original developers may have only 3 interfaces device to
>> test so they write 3 here and wait for future change.
>>
>> During the HSCanT development, we actually used 4 interfaces, so the
>> limitation of 3 is not enough now. But just increase one is not
>> future-proofed. Since the channel type in gs_host_frame is u8, just
>> increase interface number limit to max size of u8 safely.
> 
> I really like the new approach you've implemented in this patch, but now
> the patch description doesn't match anymore.

The patch description has been reword in v5.

> 
> regards,
> Marc
>