linux-kernel - Re: [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83de6105-ef4c-48dc-8960-430893ae253e@oss.qualcomm.com>
Date: Tue, 30 Sep 2025 10:17:41 +0800
From: Baochen Qiang <baochen.qiang@....qualcomm.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: jjohnson@...nel.org, ath11k@...ts.infradead.org,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] wifi: ath11k: Add missing platform IDs for quirk table



On 9/30/2025 3:21 AM, Mark Pearson wrote:
> Lenovo platforms can come with one of two different IDs.
> The pm_quirk table was missing the second ID for each platform.
> 
> Add missing ID and some extra platform identification comments.
> Reported on https://bugzilla.kernel.org/show_bug.cgi?id=219196
> 
> Tested-on: P14s G4 AMD.

Leave a blank line as 'Tested-on:' is not an official tag

> Fixes: ce8669a27016 ("wifi: ath11k: determine PM policy based on machine model")

Better to move the bugzilla link here and reword as below?

Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219196

> Signed-off-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
> ---
> Changes in v2:
>  - Correct typo for T14s G4 AMD to use correct ID. Sorry!
>  - Added in Fixes and Tested-on tags correctly.
> 
>  drivers/net/wireless/ath/ath11k/core.c | 54 +++++++++++++++++++++++---
>  1 file changed, 48 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
> index d49353b6b2e7..47522fa186a1 100644
> --- a/drivers/net/wireless/ath/ath11k/core.c
> +++ b/drivers/net/wireless/ath/ath11k/core.c
> @@ -912,42 +912,84 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
>  static const struct dmi_system_id ath11k_pm_quirk_table[] = {
>  	{
>  		.driver_data = (void *)ATH11K_PM_WOW,
> -		.matches = {
> +		.matches = { /* X13 G4 AMD #1 */
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21J3"),
> +		},
> +	},
> +	{
> +		.driver_data = (void *)ATH11K_PM_WOW,
> +		.matches = { /* X13 G4 AMD #2 */
>  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "21J4"),
>  		},
>  	},
>  	{
>  		.driver_data = (void *)ATH11K_PM_WOW,
> -		.matches = {
> +		.matches = { /* T14 G4 AMD #1 */
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21K3"),
> +		},
> +	},
> +	{
> +		.driver_data = (void *)ATH11K_PM_WOW,
> +		.matches = { /* T14 G4 AMD #2 */
>  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "21K4"),
>  		},
>  	},
>  	{
>  		.driver_data = (void *)ATH11K_PM_WOW,
> -		.matches = {
> +		.matches = { /* P14s G4 AMD #1 */
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
> +		},
> +	},
> +	{
> +		.driver_data = (void *)ATH11K_PM_WOW,
> +		.matches = { /* P14s G4 AMD #2 */
>  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "21K6"),
>  		},
>  	},
>  	{
>  		.driver_data = (void *)ATH11K_PM_WOW,
> -		.matches = {
> +		.matches = { /* T16 G2 AMD #1 */
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21K7"),
> +		},
> +	},
> +	{
> +		.driver_data = (void *)ATH11K_PM_WOW,
> +		.matches = { /* T16 G2 AMD #2 */
>  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "21K8"),
>  		},
>  	},
>  	{
>  		.driver_data = (void *)ATH11K_PM_WOW,
> -		.matches = {
> +		.matches = { /*P16s G2 AMD #1 */
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21K9"),
> +		},
> +	},
> +	{
> +		.driver_data = (void *)ATH11K_PM_WOW,
> +		.matches = { /*P16s G2 AMD #2 */
>  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "21KA"),
>  		},
>  	},
>  	{
>  		.driver_data = (void *)ATH11K_PM_WOW,
> -		.matches = {
> +		.matches = { /*T14s G4 AMD #1 */
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21F8"),
> +		},
> +	},
> +	{
> +		.driver_data = (void *)ATH11K_PM_WOW,
> +		.matches = { /*T14s G4 AMD #2 */
>  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "21F9"),
>  		},

assuming Jeff can resolve above nits ...

Reviewed-by: Baochen Qiang <baochen.qiang@....qualcomm.com>