linux-kernel - [PATCH v1] nvmem: core: update cell->bytes after shifting bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250930142212.521925-1-emil.renner.berthing@canonical.com>
Date: Tue, 30 Sep 2025 16:22:11 +0200
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: linux-kernel@...r.kernel.org
Cc: Srinivas Kandagatla <srini@...nel.org>,
	Samuel Holland <samuel@...lland.org>,
	Dmitry Baryshkov <lumag@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [PATCH v1] nvmem: core: update cell->bytes after shifting bits

When support for bit offsets of more than one byte was added it
unfortunately left the cell->bytes value at the number of bytes read
including the offset. Make sure to update it to the proper number of
meaningful bytes in the returned data.

Fixes: 7a06ef751077 ("nvmem: core: fix bit offsets of more than one byte")
Signed-off-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>
---
 drivers/nvmem/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 387c88c55259..5f6d22545e39 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -1640,6 +1640,8 @@ static void nvmem_shift_read_buffer_in_place(struct nvmem_cell_entry *cell, void
 	/* clear msb bits if any leftover in the last byte */
 	if (cell->nbits % BITS_PER_BYTE)
 		*p &= GENMASK((cell->nbits % BITS_PER_BYTE) - 1, 0);
+
+	cell->bytes = (p - (u8 *)buf) + 1;
 }
 
 static int __nvmem_cell_read(struct nvmem_device *nvmem,
-- 
2.43.0