linux-kernel - Re: [PATCH] kconfig: Avoid prompting for transitional symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202509300758.B53A1AF@keescook>
Date: Tue, 30 Sep 2025 07:59:56 -0700
From: Kees Cook <kees@...nel.org>
To: Vegard Nossum <vegard.nossum@...cle.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>, Petr Vorel <pvorel@...e.cz>,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] kconfig: Avoid prompting for transitional symbols

On Tue, Sep 30, 2025 at 08:25:06AM +0200, Vegard Nossum wrote:
> On 30/09/2025 06:53, Kees Cook wrote:
> > [...]
> > +			if (sym->type == S_BOOLEAN || sym->type == S_TRISTATE)
> > +				sym->def[S_DEF_USER].tri = newval.tri;
> > +			else
> > +				sym->def[S_DEF_USER].val = newval.val;
> 
> sym->def[S_DEF_USER] and newval are both 'struct symbol_value', can we
> just unconditionally do this instead?
> 
>     sym->def[S_DEF_USER] = newval;

Argh, yes. I even went and looked at that struct to see if tri and val
were a union and my brain didn't get to the next step. :P

I'll update this.

> I have to run, will take a closer look later. Thanks,

Thanks!

-- 
Kees Cook