linux-kernel - Re: [PATCH] stable: crypto: sha256

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251001165455.GF1592@sol>
Date: Wed, 1 Oct 2025 09:54:55 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: gregkh@...uxfoundation.org, sashal@...nel.org, stable@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Ard Biesheuvel <ardb@...nel.org>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...a.com,
	Michael van der Westhuizen <rmikey@...a.com>,
	Tobias Fleig <tfleig@...a.com>
Subject: Re: [PATCH] stable: crypto: sha256 - fix crash at kexec

On Wed, Oct 01, 2025 at 09:45:07AM -0700, Breno Leitao wrote:
> Hello Eric,
> 
> On Wed, Oct 01, 2025 at 09:23:05AM -0700, Eric Biggers wrote:
> 
> > This looks fine, but technically 'unsigned int' would be more
> > appropriate here, given the context.  If we look at the whole function
> > in 6.12, we can see that it took an 'unsigned int' length:
> 
> Ack. Do you want me to send a v2 with `unsigned int` instead?
> 

Sure.  Could you also make it clear which kernel version(s) you are
expecting the patch to be applied to?  Is it everything 5.4 through
6.15?  It looks like this bug actually got exposed by f4da7afe07523f
("kexec_file: increase maximum file size to 4G") in 6.0.  But
backporting to older versions should be fine too, if it applies to them.

- Eric