linux-kernel - Re: [GIT PULL] gpio updates for v6.18-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whnmvjsan9Y=LcV0encJungD451VkdqYAKrRpk6YyA6-w@mail.gmail.com>
Date: Wed, 1 Oct 2025 11:36:03 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [GIT PULL] gpio updates for v6.18-rc1

On Mon, 29 Sept 2025 at 02:41, Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> Here's the PR containing the GPIO updates for this merge window. There are
> two new drivers and support for more models in existing ones.

This appears to not have been build-tested AT ALL.

> - allow building gpio-stmpe as a module

This causes build errors:

  ERROR: modpost: missing MODULE_LICENSE() in drivers/mfd/stmpe-i2c.o
  ERROR: modpost: missing MODULE_LICENSE() in drivers/mfd/stmpe-spi.o

because while the main core stmpe.c driver got an added

  MODULE_LICENSE("GPL");

when it was turned into a modular build, the SPI and i2c modules did not.

It's trivial to fix, but I should not be in the situation where I have
to fix it, and I should not be getting pull requests that don't even
build under trivial configurations.

How the hell did this happen? Where was the basic build testing?

                            Linus