linux-kernel - Re: [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt to trivial-touch.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aN2eWrTWsonkchJT@lizhi-Precision-Tower-5810>
Date: Wed, 1 Oct 2025 17:34:18 -0400
From: Frank Li <Frank.li@....com>
To: Conor Dooley <conor@...nel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." <linux-input@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt to
 trivial-touch.yaml

On Tue, Sep 30, 2025 at 08:05:56PM +0100, Conor Dooley wrote:
> On Fri, Sep 26, 2025 at 02:47:12PM -0400, Frank Li wrote:
> > ar1021 have only reg and interrupts property beside touch common
> > properties. So move context of ar1021.txt into trivial-touch.yaml.
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> > change in v2
> >  move to trivial-touch.yaml
> >
> > previous discussion
> >     https://lore.kernel.org/imx/20250925-swimming-overspend-ddf7ab4a252c@spud/T/#t
>
> You mentioned there were a load of other devices using just these 3
> properties. Do you intend moving those too?

I go through other yaml, I have not found more. But there are somes, which
have one additonal properties reset-gpios.

If add 'reset-gpios' as optional property here, I can move more these into
this files. But I am not sure if it is good idea to lose restriction or
use if branch in trivial-touch.yaml.

In other trivial-*.yaml, there are one reset-gpios and one power-supply.

Frank
>
> > ---
> >  .../bindings/input/touchscreen/ar1021.txt         | 15 ---------------
> >  .../bindings/input/touchscreen/trivial-touch.yaml |  2 ++
> >  2 files changed, 2 insertions(+), 15 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt b/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> > deleted file mode 100644
> > index 82019bd6094ee..0000000000000
> > --- a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> > +++ /dev/null
> > @@ -1,15 +0,0 @@
> > -* Microchip AR1020 and AR1021 touchscreen interface (I2C)
> > -
> > -Required properties:
> > -- compatible		: "microchip,ar1021-i2c"
> > -- reg			: I2C slave address
> > -- interrupts		: touch controller interrupt
> > -
> > -Example:
> > -
> > -	touchscreen@4d {
> > -		compatible = "microchip,ar1021-i2c";
> > -		reg = <0x4d>;
> > -		interrupt-parent = <&gpio3>;
> > -		interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> > -	};
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> > index c393cce273c5b..d6aed3afd4acb 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> > @@ -14,6 +14,8 @@ properties:
> >      enum:
> >        # MAXI MAX11801 Resistive touch screen controller with i2c interface
> >        - maxim,max11801
> > +      # Microchip AR1020 and AR1021 touchscreen interface (I2C)
> > +      - microchip,ar1021-i2c
> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.34.1
> >