linux-kernel - Re: [RFC PATCH 0/2] rust: bounded integer types and use in register macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d4b5659-7c0e-4720-8305-5b0053807443@nvidia.com>
Date: Wed, 1 Oct 2025 18:07:59 -0400
From: Joel Fernandes <joelagnelf@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>, Yury Norov
 <yury.norov@...il.com>, Danilo Krummrich <dakr@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 0/2] rust: bounded integer types and use in register
 macro

Hi Alex,

Nice!

On 10/1/2025 11:03 AM, Alexandre Courbot wrote:
> For convenience, this PoC is based on drm-rust-next. If we decide to
> proceed with it, we would do it after the patchset extracting and moving
> the bitfield logic [3] lands, as the two would conflict heavily.

I would strongly prefer this as well, to avoid conflicts. On initial look, this
seems to be in the right direction and solves the pain points we were seeing.

-            .set_sec(if sec { 1 } else { 0 });
+            .set_sec_bounded(BoundedInt::new(if sec { 1 } else { 0 }));

Here, I would prefer if we did not add _bounded, since the idea is to solve the
problems in the macro's setters itself (make it infallible, not panicking etc).
So we can just modify those?

Also, BoundedInt sounds like a good name to me IMO.

Also, since TryFrom trait is implemented in the first patch, then in nova we can
just do the following?
  .set_foo(value.try_into()?);

That's slightly simpler to read than:
  .set_foo(BoundedInt::try_from(value)?);

And closer to the old syntax of
  .set_foo(value); // used to truncate

But I don't feel strongly about not using the full form version.

thanks,

 - Joel