linux-kernel - Re: [PATCH v2 2/3] alpha: don't reference obsolete termio struct for TC* constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ms6axnqc.fsf@gentoo.org>
Date: Wed, 01 Oct 2025 23:26:35 +0100
From: Sam James <sam@...too.org>
To: Magnus Lindholm <linmag7@...il.com>
Cc: Richard Henderson <richard.henderson@...aro.org>,  Matt Turner
 <mattst88@...il.com>,  Stian Halseth <stian@....no>,
  linux-alpha@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] alpha: don't reference obsolete termio struct
 for TC* constants

Magnus Lindholm <linmag7@...il.com> writes:

>> +#define TCGETA          0x5405
>> +#define TCSETA          0x5406
>> +#define TCSETAW         0x5407
>> +#define TCSETAF         0x5408
>
> Hi,
>
> A similar patch aimed for powerpc (commit ab10727) had the following
> definitions:
>
> #define TCGETA    0x40147417
> #define TCSETA    0x80147418
> #define TCSETAW 0x80147419
> #define TCSETAF  0x8014741c
>
> On Alpha, if I do something like printf("TCGETA = 0x%08x\n", TCGETA);
> I get TCGETA = 0x40127417, but on an intel/x64 I get 0x5405.
> Is this something we need to consider here?

There are fallback definitions in generic:

tools/include/uapi/asm-generic/ioctls.h:24:#define TCGETA               0x5405
include/uapi/asm-generic/ioctls.h:24:#define TCGETA             0x5405

I think those are used where there was no historical value (i.e. for
newer ioctls). Coud you run something like
https://bugs.gentoo.org/962600#c5 to get the full list of (removed)
constant values for alpha? It's awkward for me to test with older glibc.

>
> Regards
>
> Magnus

thanks,
sam