linux-kernel - Re: [PATCH 0/2] rust: pci: expose is_virtfn() and reject VFs in nova-core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7bd8285-922e-446f-9b43-a67fff67a505@nvidia.com>
Date: Wed, 1 Oct 2025 16:51:42 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Joel Fernandes <joelagnelf@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>, Zhi Wang <zhiw@...dia.com>,
 Alistair Popple <apopple@...dia.com>, Alexandre Courbot
 <acourbot@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Surath Mitra <smitra@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
 "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
 "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>, Jason Gunthorpe <jgg@...dia.com>,
 Alex Williamson <alex.williamson@...hat.com>
Subject: Re: [PATCH 0/2] rust: pci: expose is_virtfn() and reject VFs in
 nova-core

On 10/1/25 4:47 PM, Joel Fernandes wrote:
>> On Oct 1, 2025, at 7:00 PM, John Hubbard <jhubbard@...dia.com> wrote:
>> On 10/1/25 3:52 PM, Danilo Krummrich wrote:
>>>> On Thu Oct 2, 2025 at 12:38 AM CEST, John Hubbard wrote:
>>>> On 10/1/25 6:52 AM, Zhi Wang wrote:
>>>>> On 1.10.2025 13.32, Danilo Krummrich wrote:
>>>>>> On Wed Oct 1, 2025 at 3:22 AM CEST, John Hubbard wrote:
>>>>>>> On 9/30/25 5:29 PM, Alistair Popple wrote:
>>>>>>>> On 2025-10-01 at 08:07 +1000, John Hubbard <jhubbard@...dia.com> wrote...
>>>> ...
> Here is my opinion and correct me if I missed something:
> 
> It feels premature to remove the option of nova-core binding to a VF, since other options to disable auto probing do exist as Jason pointed out.
> 
> Taking a parallel with VFIO pass through for instance, the user already has to do some diligence like preventing drivers from binding and then making vfio-pci bind to the device IDs. This case is similar though slightly different, but VFIO setup requires some configuration anyway so will it really improve anything?
> 
> I quietly suggest holding on till there is a real need or we are sure nova cannot bind to, or operate on a VF. This 

I'm confident that nova-core cannot properly handle a VF with *today's* code.
There is no expectation at all for a VF to show up--yet.

Which is why I think it's appropriate to skip it right now.

thanks,
-- 
John Hubbard