linux-kernel - Re: [PATCH v1] gpio: gpio-grgpio: call request_irq after incrementing the reference count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZdfcqoX4bQfi1hFTmKPfZcumBFC4tNVrAODGWQJ8bTxw@mail.gmail.com>
Date: Wed, 1 Oct 2025 10:29:33 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Alex Tran <alex.t.tran@...il.com>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] gpio: gpio-grgpio: call request_irq after incrementing
 the reference count

On Sun, Sep 28, 2025 at 7:41 AM Alex Tran <alex.t.tran@...il.com> wrote:

> Remove extraneous dropping of the lock just to call 'request_irq'
> and locking again afterwards. Increment reference count
> before calling 'request_irq'. Rollback reference count if
> 'request_irq' fails.
>
> Signed-off-by: Alex Tran <alex.t.tran@...il.com>

This looks right.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij