linux-kernel - Re: [PATCH net-next 0/8] mptcp: receive path improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ee6e86a-298b-41e9-971a-a40c1f96ec83@kernel.org>
Date: Wed, 1 Oct 2025 10:50:08 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Mat Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...gle.com>,
 David Ahern <dsahern@...nel.org>, Shuah Khan <shuah@...nel.org>,
 netdev@...r.kernel.org, mptcp@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 0/8] mptcp: receive path improvement

Hi Jakub,

On 30/09/2025 03:27, Jakub Kicinski wrote:
> On Sat, 27 Sep 2025 11:40:36 +0200 Matthieu Baerts (NGI0) wrote:
>> This series includes several changes to the MPTCP RX path. The main
>> goals are improving the RX performances, and increase the long term
>> maintainability.
>>
>> Some changes reflects recent(ish) improvements introduced in the TCP
>> stack: patch 1, 2 and 3 are the MPTCP counter part of SKB deferral free
>> and auto-tuning improvements. Note that patch 3 could possibly fix
>> additional issues, and overall such patch should protect from similar
>> issues to arise in the future.
>>
>> Patches 4-7 are aimed at introducing the socket backlog usage which will
>> be done in a later series to process the packets received by the
>> different subflows while the msk socket is owned.
>>
>> Patch 8 is not related to the RX path, but it contains additional tests
>> for new features recently introduced in net-next.
> 
> Could be a coincidence but we got 3 simult_flows.sh flakes since this
> was posted. Previous one was 20+ days ago:
> https://netdev.bots.linux.dev/contest.html?ld_cnt=250&pw-pass=n&pass=0&test=simult-flows-sh

Thank you for this message! Our CI didn't spot this issue in the last 2
weeks. I see it happened again on NIPA (sorry for that, and thank you
for having ignored this selftest) so I guess it is not a coincidence,
I'm going to investigate this issue ASAP.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.