linux-kernel - Re: [PATCH] KVM: s390: Remove unused return variable in kvm_arch_vcpu_ioctl_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18a1c26f-036a-44c3-9c53-82cd86d79340@linux.ibm.com>
Date: Wed, 1 Oct 2025 11:32:17 +0200
From: Janosch Frank <frankja@...ux.ibm.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev
 <agordeev@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>
Cc: kvm@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: s390: Remove unused return variable in
 kvm_arch_vcpu_ioctl_set_fpu

On 9/16/25 3:12 PM, Thorsten Blum wrote:
> kvm_arch_vcpu_ioctl_set_fpu() always returns 0 and the local return
> variable 'ret' is not used anymore. Remove it.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>

Thanks, picked

> ---
>   arch/s390/kvm/kvm-s390.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index bf6fa8b9ca73..f61cb8a5ea77 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -4367,8 +4367,6 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
>   
>   int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
>   {
> -	int ret = 0;
> -
>   	vcpu_load(vcpu);
>   
>   	vcpu->run->s.regs.fpc = fpu->fpc;
> @@ -4379,7 +4377,7 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
>   		memcpy(vcpu->run->s.regs.fprs, &fpu->fprs, sizeof(fpu->fprs));
>   
>   	vcpu_put(vcpu);
> -	return ret;
> +	return 0;
>   }
>   
>   int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)