linux-kernel - Re: [PATCH v2 05/10] gpu: nova-core: gsp: Add GSP command queue handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24jk3p4e3i736fmu6532swihx5ldpxwzpgiyxqjkrklmhh476o@bbwezcponqfx>
Date: Wed, 1 Oct 2025 10:42:49 +1000
From: Alistair Popple <apopple@...dia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Alexandre Courbot <acourbot@...dia.com>, 
	rust-for-linux@...r.kernel.org, dri-devel@...ts.freedesktop.org, dakr@...nel.org, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	John Hubbard <jhubbard@...dia.com>, Joel Fernandes <joelagnelf@...dia.com>, 
	Timur Tabi <ttabi@...dia.com>, linux-kernel@...r.kernel.org, nouveau@...ts.freedesktop.org
Subject: Re: [PATCH v2 05/10] gpu: nova-core: gsp: Add GSP command queue
 handling

On 2025-09-30 at 21:58 +1000, Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote...
> On Tue, Sep 30, 2025 at 1:42 PM Alistair Popple <apopple@...dia.com> wrote:
> >
> > Thanks. Is it still expected that `#[allow(clippy::incompatible_msrv)]` is
> > required? Just adding it to `rust_allowed_features` doesn't make the warning go
> > away without the allow, but maybe I'm just doing something wrong...
> 
> The warning is independent of the allowed features, and yeah, it is
> expected that the Clippy may trigger (at this moment when we dance
> with these features), so you can just allow it locally.
> 
> If it is too cumbersome, I may disable it globally.
> 
> I hope that helps!

Thanks! That does help, it's not too cumbersome as we only use it in a few
places. I was just wondering if it was expected or not. A nice future quality
of life improvement might be to automatically disable clippy warnings for
everything in `rust_allowed_features` but I think that's pretty low priority.

> Cheers,
> Miguel