linux-kernel - Re: [PATCH] ASoC: codecs: Fix the error of excessive semicolons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DD6Y4WZD1ZMK.3E0AUSVO0W79P@linaro.org>
Date: Wed, 01 Oct 2025 12:24:32 +0100
From: "Alexey Klimov" <alexey.klimov@...aro.org>
To: "TangBin" <tangbin@...s.chinamobile.com>
Cc: <srini@...nel.org>, <lgirdwood@...il.com>, <broonie@...nel.org>,
 <perex@...ex.cz>, <tiwai@...e.com>, <linux-sound@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: codecs: Fix the error of excessive semicolons

On Tue Sep 30, 2025 at 10:41 AM BST, TangBin wrote:
> From: Tang Bin <tangbin@...s.chinamobile.com>
>
> Remove unnecessary semicolons in the function
> pm4125_codec_enable_adc and pm4125_micbias_control.
>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>

Please use better email/commit subject or title.
I'd say that something like "ASoC: codecs: pm4125: ... " would be better
to reflect which codec this change relates to.


> ---
>  sound/soc/codecs/pm4125.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/pm4125.c b/sound/soc/codecs/pm4125.c
> index 706fc668f..aa8319c4a 100644
> --- a/sound/soc/codecs/pm4125.c
> +++ b/sound/soc/codecs/pm4125.c
> @@ -691,7 +691,7 @@ static int pm4125_codec_enable_adc(struct snd_soc_dapm_widget *w,
>  						      0x00);
>  		pm4125_global_mbias_disable(component);
>  		break;
> -	};
> +	}
>  
>  	return 0;
>  }
> @@ -756,7 +756,7 @@ static int pm4125_micbias_control(struct snd_soc_component *component, int micb_
>  		dev_err(component->dev, "%s: Invalid micbias number: %d\n",
>  			__func__, micb_num);
>  		return -EINVAL;
> -	};
> +	}
>  
>  	switch (req) {
>  	case MICB_PULLUP_ENABLE:
> @@ -799,7 +799,7 @@ static int pm4125_micbias_control(struct snd_soc_component *component, int micb_
>  			pm4125_global_mbias_disable(component);
>  		}
>  		break;
> -	};
> +	}

Thanks for noticing this.

Looks like checkpatch.pl --strict generates a bit of more warnings for this file.

Best regards,
Alexey