linux-kernel - Re: [PATCH RESEND v5 03/13] spi: airoha: add support of dual/quad wires spi modes to exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55975f94-3655-480c-be9e-ac4075c60a7d@collabora.com>
Date: Wed, 1 Oct 2025 13:34:13 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Ray Liu <ray.liu@...oha.com>,
 Mark Brown <broonie@...nel.org>, Andy Shevchenko <andy@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Andreas Gnau <andreas.gnau@...sys.eu>
Subject: Re: [PATCH RESEND v5 03/13] spi: airoha: add support of dual/quad
 wires spi modes to exec_op() handler

Il 30/09/25 04:26, Mikhail Kshevetskiy ha scritto:
> Booting without this patch and disabled dirmap support results in
> 
> [    2.980719] spi-nand spi0.0: Micron SPI NAND was found.
> [    2.986040] spi-nand spi0.0: 256 MiB, block size: 128 KiB, page size: 2048, OOB size: 128
> [    2.994709] 2 fixed-partitions partitions found on MTD device spi0.0
> [    3.001075] Creating 2 MTD partitions on "spi0.0":
> [    3.005862] 0x000000000000-0x000000020000 : "bl2"
> [    3.011272] 0x000000020000-0x000010000000 : "ubi"
> ...
> [    6.195594] ubi0: attaching mtd1
> [   13.338398] ubi0: scanning is finished
> [   13.342188] ubi0 error: ubi_read_volume_table: the layout volume was not found
> [   13.349784] ubi0 error: ubi_attach_mtd_dev: failed to attach mtd1, error -22
> [   13.356897] UBI error: cannot attach mtd1
> 
> If dirmap is disabled or not supported in the spi driver, the dirmap requests
> will be executed via exec_op() handler. Thus, if the hardware supports
> dual/quad spi modes, then corresponding requests will be sent to exec_op()
> handler. Current driver does not support such requests, so error is arrised.
> As result the flash can't be read/write.
> 
> This patch adds support of dual and quad wires spi modes to exec_op() handler.
> 
> Fixes: a403997c12019 ("spi: airoha: add SPI-NAND Flash controller driver")
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>