linux-kernel - Re: [PATCH] fs: assert ->i_lock held in _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <u3hbbwmmzdk6w4xehqyutp3zd3bfnilgxk7wtpvb55upl7ar5n@upbub3qtjh4p>
Date: Wed, 1 Oct 2025 13:54:38 +0200
From: Jan Kara <jack@...e.cz>
To: Mateusz Guzik <mjguzik@...il.com>
Cc: brauner@...nel.org, viro@...iv.linux.org.uk, jack@...e.cz, 
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs: assert ->i_lock held in __iget()

On Wed 01-10-25 01:53:14, Mateusz Guzik wrote:
> Also remove the now redundant comment.
> 
> Signed-off-by: Mateusz Guzik <mjguzik@...il.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
> 
> verified this booted with ext4 on root, no splats
> 
>  include/linux/fs.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 9e9d7c757efe..4c773c4ee7aa 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -3368,11 +3368,9 @@ static inline bool is_zero_ino(ino_t ino)
>  	return (u32)ino == 0;
>  }
>  
> -/*
> - * inode->i_lock must be held
> - */
>  static inline void __iget(struct inode *inode)
>  {
> +	lockdep_assert_held(&inode->i_lock);
>  	atomic_inc(&inode->i_count);
>  }
>  
> -- 
> 2.34.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR