linux-kernel - Re: [PATCH] perf/annotate: Use architecture-agnostic register limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aN03YZ-GkfTyOD8Z@x1>
Date: Wed, 1 Oct 2025 11:14:57 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Suchit Karunakaran <suchitkarunakaran@...il.com>, peterz@...radead.org,
	mingo@...hat.com, namhyung@...nel.org, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
	adrian.hunter@...el.com, kan.liang@...ux.intel.com,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH] perf/annotate: Use architecture-agnostic register limit

On Tue, Sep 23, 2025 at 12:11:27PM -0700, Ian Rogers wrote:
> On Tue, Sep 23, 2025 at 10:43 AM Suchit Karunakaran
> <suchitkarunakaran@...il.com> wrote:
> >
> > Remove the arch-specific guard around TYPE_STATE_MAX_REGS and define it
> > as 32 for all architectures. The architecture that perf is built on may
> > not match the architecture that produced the perf.data file, so relying
> > on __powerpc__ or similar is fragile. Using 32 as a fixed upper bound is
> > safe since it is greater than the previous maximum of 16.
> > Add a comment to clarify that TYPE_STATE_MAX_REGS is an arch-independent
> > maximum rather than a build-time choice.
> >
> > Suggested-by: Ian Rogers <irogers@...gle.com>
> > Signed-off-by: Suchit Karunakaran <suchitkarunakaran@...il.com>
> 
> Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks, applied to perf-tools-next,

- Arnaldo