linux-kernel - Re: [PATCH] slimbus: qcom: remove unused qcom controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3147370-11da-4202-abac-36218487578f@oss.qualcomm.com>
Date: Wed, 1 Oct 2025 16:03:49 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
To: Srinivas Kandagatla <srini@...nel.org>, Rob Herring <robh@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org,
        linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] slimbus: qcom: remove unused qcom controller driver

On 10/1/25 3:21 PM, Srinivas Kandagatla wrote:
> 
> 
> On 10/1/25 3:19 PM, Rob Herring wrote:
>> +Greg
>>
>> On Fri, Sep 19, 2025 at 12:25 PM Rob Herring <robh@...nel.org> wrote:
>>>
>>> On Fri, Sep 5, 2025 at 12:30 AM Srinivas Kandagatla <srini@...nel.org> wrote:
>>>>
>>>>
>>>>
>>>> On 9/5/25 12:08 AM, Rob Herring wrote:
>>>>> On Tue, Aug 19, 2025 at 8:44 AM Srinivas Kandagatla
>>>>> <srinivas.kandagatla@....qualcomm.com> wrote:
>>>>>>
>>>>>> Thanks Rob for reporting this,
>>>>>>
>>>>>> On 8/19/25 2:35 PM, Rob Herring wrote:
>>>>>>> On Thu, Jul 24, 2025 at 8:28 AM <srinivas.kandagatla@....qualcomm.com> wrote:
>>>>>>>>
>>>>>>>> From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
>>>>>>>>
>>>>>>>> Qcom Slimbus controller driver is totally unused and dead code, there is
>>>>>>>> no point in keeping this driver in the kernel without users.
>>>>>>>>
>>>>>>>> This patch removes the driver along with device tree bindings.
>>>>>>>>
>>>>>>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
>>>>>>>> ---
>>>>>>>>  .../bindings/slimbus/qcom,slim.yaml           |  86 --
>>>>>>>>  drivers/slimbus/Kconfig                       |   7 -
>>>>>>>>  drivers/slimbus/Makefile                      |   3 -
>>>>>>>>  drivers/slimbus/qcom-ctrl.c                   | 735 ------------------
>>>>>>>>  4 files changed, 831 deletions(-)
>>>>>>>>  delete mode 100644 Documentation/devicetree/bindings/slimbus/qcom,slim.yaml
>>>>>>>>  delete mode 100644 drivers/slimbus/qcom-ctrl.c
>>>>>>>
>>>>>>> This adds warnings to dt_binding_check:
>>>>>>>
>>>>>>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>>>>>>> /example-0/soc/slim@...80000: failed to match any schema with
>>>>>>> compatible: ['qcom,apq8064-slim', 'qcom,slim']
>>>>>>
>>>>>> Will replace this example with slim-ngd and fold it in the original patch.
>>>>>
>>>>> Still warning in linux-next...
>>>> Its done now!
>>>
>>> Now I get this:
>>>
>>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>>> slim@...80000 (qcom,slim-ngd-v1.5.0): 'audio-codec@1,0' does not match
>>> any of the regexes: '^pinctrl-[0-9]+$', '^slim@[0-9a-f]+$'
>>>         from schema $id:
>>> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
>>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>>> slim@...80000 (qcom,slim-ngd-v1.5.0): #address-cells: 1 was expected
>>>         from schema $id:
>>> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
>>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>>> slim@...80000 (qcom,slim-ngd-v1.5.0): 'dmas' is a required property
>>>         from schema $id:
>>> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
>>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>>> slim@...80000 (qcom,slim-ngd-v1.5.0): 'dma-names' is a required
>>> property
>>>         from schema $id:
>>> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
>>
>> Still failing in linux-next.

I was running the check against the the yaml file which missed this
warnings, I should have run this against the folder instead which could
have caught this. May be this is something that could be improved in the
check by pulling in the dependency yamls too.


make -j`nproc` dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/slimbus/slimbus.yaml


--srini
> 
> Rob, sorry for delay..
> 
> will send a fix,
> 
> 
> --srini
> 
>>
>> Rob
>