linux-kernel - Re: [RFC 2/5] dt-bindings: pinctrl: add pic64gx "gpio2" pinmux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251001-recount-exquisite-6b304e8813b9@spud>
Date: Wed, 1 Oct 2025 16:48:04 +0100
From: Conor Dooley <conor@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Conor Dooley <conor.dooley@...rochip.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [RFC 2/5] dt-bindings: pinctrl: add pic64gx "gpio2" pinmux

On Wed, Oct 01, 2025 at 04:47:12PM +0100, Conor Dooley wrote:
> On Wed, Oct 01, 2025 at 01:32:37PM +0200, Linus Walleij wrote:
> > On Fri, Sep 26, 2025 at 4:33 PM Conor Dooley <conor@...nel.org> wrote:
> > 
> > > pin     role (1/0)
> > > ---     ----------
> > > E14     MAC_0_MDC/GPIO_2_0
> > > E15     MAC_0_MDIO/GPIO_2_1
> > > F16     MAC_1_MDC/GPIO_2_2
> > > F17     MAC_1_MDIO/GPIO_2_3
> > 
> > So this is a group you can name "mac_grp" and a function
> > you can name "mac".
> > 
> > > D19     SPI_0_CLK/GPIO_2_4
> > > B18     SPI_0_SS0/GPIO_2_5
> > (...)
> > > E19     SPI_0_DO/GPIO_2_10
> > > C7      SPI_0_DI/GPIO_2_11
> > 
> > These pins would be "spi0_grp", function "spi0".
> > 
> > etc. No need for "pinmux" properties just use classix
> > group and function strings.
> 
> tbh, I found it hard to understand the "line" between using a pinmux
> property and where stuff should be described in groups or functions in a
> driver. What is that line?

You may have noticed that I never really review pinctrl bindings, and it
is the lack of experience with this kind of decision that's why I never
do it.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)