[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251001155300.GC1833526-robh@kernel.org>
Date: Wed, 1 Oct 2025 10:53:00 -0500
From: Rob Herring <robh@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: linux-mediatek@...ts.infradead.org, lee@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, matthias.bgg@...il.com, lgirdwood@...il.com,
broonie@...nel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
kernel@...labora.com, wenst@...omium.org,
igor.belwon@...tallysanemainliners.org
Subject: Re: [PATCH v6 5/9] dt-bindings: regulator: Document MediaTek MT6373
PMIC Regulators
On Wed, Oct 01, 2025 at 01:13:12PM +0200, AngeloGioacchino Del Regno wrote:
> Add bindings for the regulators found in the MediaTek MT6363 PMIC,
> usually found in board designs using the MT6991 Dimensity 9400 and
> on MT8196 Kompanio SoC for Chromebooks, along with the MT6316 and
> MT6363 PMICs.
>
> Link: https://lore.kernel.org/r/20250715140224.206329-6-angelogioacchino.delregno@collabora.com
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
> .../regulator/mediatek,mt6373-regulator.yaml | 137 ++++++++++++++++++
> 1 file changed, 137 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6373-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6373-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6373-regulator.yaml
> new file mode 100644
> index 000000000000..cb721d81b77c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6373-regulator.yaml
> @@ -0,0 +1,137 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mediatek,mt6373-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT6373 PMIC Regulators
> +
> +maintainers:
> + - AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> +
> +description:
> + The MT6373 SPMI PMIC provides 10 BUCK and 23 LDO (Low DropOut) regulators
> + and can optionally provide overcurrent warnings with one ocp interrupt
> + for each voltage regulator.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6373-regulator
> +
> + reg:
> + maxItems: 1
> +
> + vsys-vbuck0-supply:
> + description: Input supply for vbuck0
> +
> + vsys-vbuck1-supply:
> + description: Input supply for vbuck1
> +
> + vsys-vbuck2-supply:
> + description: Input supply for vbuck2
> +
> + vsys-vbuck3-supply:
> + description: Input supply for vbuck3
> +
> + vsys-vbuck4-supply:
> + description: Input supply for vbuck4
> +
> + vsys-vbuck5-supply:
> + description: Input supply for vbuck5
> +
> + vsys-vbuck6-supply:
> + description: Input supply for vbuck6
> +
> + vsys-vbuck7-supply:
> + description: Input supply for vbuck7
> +
> + vsys-vbuck8-supply:
> + description: Input supply for vbuck8
> +
> + vsys-vbuck9-supply:
> + description: Input supply for vbuck9
> +
> + vs1-ldo1-supply:
> + description: Input supply for vant18, vaud18, vcn18io
> +
> + vs2-ldo1-supply:
> + description: Input supply for vrf12-aif, vrf13-aif
> +
> + vs3-ldo1-supply:
> + description: Input supply for vrf09-aif, vsram-digrf-aif
> +
> + vsys-ldo1-supply:
> + description: Input supply for vcn33-1, vcn33-2, vmc
> +
> + vsys-ldo2-supply:
> + description:
> + Input supply for vaux18, vcn33-3, vefuse, vfp, vibr, vio28, vtp, vusb
> +
> + vsys-ldo3-supply:
> + description: Input supply for vmch, vmch-eint-high/low
> +
> +patternProperties:
> + "^v(ant|aud|aux)18$":
> + $ref: "#/$defs/mediatek-mt6373-ldo-common"
> +
> + "^vbuck([0-9])$":
Don't need ().
> + type: object
> + $ref: regulator.yaml#
> + properties:
> + regulator-allowed-modes:
> + description: |
> + Allowed Buck regulator operating modes allowed. Valid values below.
> + 0 - Normal mode with automatic power saving, reducing the switching
> + frequency when light load conditions are detected
> + 1 - Forced Continuous Conduction mode (FCCM) for improved voltage
> + regulation accuracy with constant switching frequency but lower
> + regulator efficiency
> + 2 - Forced Low Power mode for improved regulator efficiency, used
> + when no heavy load is expected, does not limit the maximum out
> + current but unless only a light load is applied, there will be
> + regulation accuracy and efficiency losses.
> + 3 - Forced Ultra Low Power mode for ultra low load, this greatly
> + reduces the maximum output power, makes the regulator to be
> + efficient only for ultra light load, and greatly reduces the
> + quiescent current (Iq) of the buck.
> + maxItems: 3
> + items:
> + enum: [ 0, 1, 2, 3 ]
> + unevaluatedProperties: false
> +
> + "^v(cn18io|cn33-[123]|efuse|fp|tp|ibr|io28|sram-digrf-aif|usb)":
Missing '$' anchor.
> + $ref: "#/$defs/mediatek-mt6373-ldo-common"
> +
> + "^vmc(h)?$":
Don't need ().
> + $ref: "#/$defs/mediatek-mt6373-ldo-common"
> +
> + "^vmch-eint-(low|high)?$":
vmch-eint- is a valid name?
> + $ref: "#/$defs/mediatek-mt6373-ldo-common"
> +
> + "^vrf(09|12|13|18|io18)-aif$":
> + $ref: "#/$defs/mediatek-mt6373-ldo-common"
> +
> +$defs:
> + mediatek-mt6373-ldo-common:
The name is local to the schema, so 'ldo-common' would be sufficient.
> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
> + properties:
> + regulator-allowed-modes:
> + description: |
> + Allowed LDO regulator operating modes allowed. Valid values below.
> + 0 - Normal mode with automatic power saving, reducing the switching
> + frequency when light load conditions are detected
> + 2 - Forced Low Power mode for improved regulator efficiency, used
> + when no heavy load is expected, does not limit the maximum out
> + current but unless only a light load is applied, there will be
> + regulation accuracy and efficiency losses.
> + maxItems: 2
> + items:
> + enum: [ 0, 2 ]
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> --
> 2.51.0
>
Powered by blists - more mailing lists