linux-kernel - Re: [PATCH RFC] usb: typec: thunderbolt: Fix Thunderbolt adapter type bitfield values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMFSARdM6CmUwfntnbG3THsOFC33KyZnR1RVLXmYwFJum+5K=A@mail.gmail.com>
Date: Thu, 2 Oct 2025 12:30:39 -0700
From: Jameson Thies <jthies@...gle.com>
To: Tzung-Bi Shih <tzungbi@...nel.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>, 
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Benson Leung <bleung@...omium.org>, 
	Abhishek Pandit-Subedi <abhishekpandit@...omium.org>, Andrei Kuchynski <akuchynski@...omium.org>, 
	Guenter Roeck <groeck@...omium.org>, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev, 
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH RFC] usb: typec: thunderbolt: Fix Thunderbolt adapter type
 bitfield values

Hi Konrad,
thanks for raising this. Yes, it looks like this works around the
current faulty definitions in typec_tbt.h. Where
pd_ctrl->control_flags is assigned in our EC firmware, the
USB_PD_CTRL_TBT_LEGACY_ADAPTER correctly gets set to 1 for TBT2 legacy
adapters. So the data.device_mode assignment you are updating here is
currently correct even though the macro is incorrect. Your patch LGTM.