linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: add missing dput() when printing the donation list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACOAw_yyUJUQ6zzHYy+yFY-bOhQ_=hAnPQ_acuNk4KCaQn-Tvg@mail.gmail.com>
Date: Thu, 2 Oct 2025 13:23:50 -0700
From: Daeho Jeong <daeho43@...il.com>
To: Jaegeuk Kim <jaegeuk@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: add missing dput() when printing the
 donation list

On Wed, Oct 1, 2025 at 6:59 PM Jaegeuk Kim via Linux-f2fs-devel
<linux-f2fs-devel@...ts.sourceforge.net> wrote:
>
> We missed to call dput() on the grabbed dentry.
>
> Fixes: f1a49c1b112b ("f2fs: show the list of donation files")
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>  fs/f2fs/sysfs.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index 7992386fb9e6..6d2a4fba68a2 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -1845,6 +1845,7 @@ static int __maybe_unused donation_list_seq_show(struct seq_file *seq,
>                                 (loff_t)(fi->donate_end + 1) << (PAGE_SHIFT - 10),
>                                 (loff_t)inode->i_mapping->nrpages << (PAGE_SHIFT - 10));
>  next:
> +               dput(dentry);
>                 inode_unlock_shared(inode);
>                 iput(inode);
>         }
> --
> 2.51.0.618.g983fd99d29-goog
>
>

Reviewed-by: Daeho Jeong <daehojeong@...gle.com>

Thanks,

>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel