linux-kernel - Re: [PATCH hyperv-next] hyperv: Remove the spurious null directive line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251002212148.GB925245@liuwe-devbox-debian-v2.local>
Date: Thu, 2 Oct 2025 21:21:48 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Easwar Hariharan <easwar.hariharan@...ux.microsoft.com>
Cc: Roman Kisel <romank@...ux.microsoft.com>, decui@...rosoft.com,
	eahariha@...ux.microsoft.com, haiyangz@...rosoft.com,
	kys@...rosoft.com, mhklinux@...look.com,
	nunodasneves@...ux.microsoft.com, wei.liu@...nel.org,
	linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
	benhill@...rosoft.com, bperkins@...rosoft.com,
	sunilmut@...rosoft.com
Subject: Re: [PATCH hyperv-next] hyperv: Remove the spurious null directive
 line

On Thu, Oct 02, 2025 at 09:04:21AM -0700, Easwar Hariharan wrote:
> On 10/1/2025 4:08 PM, Roman Kisel wrote:
> > The file contains a line that consists of the lone # symbol
> > followed by a newline. While that is a valid syntax as
> > defined by the C99+ grammar (6.10.7 "Null directive"), it
> > serves no apparent purpose in this case.
> > 
> > Remove the null preprocessor directive. No functional changes.
> > 
> > Fixes: e68bda71a238 ("hyperv: Add new Hyper-V headers in include/hyperv")
> > Signed-off-by: Roman Kisel <romank@...ux.microsoft.com>
> > ---
> >  include/hyperv/hvgdk_mini.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/include/hyperv/hvgdk_mini.h b/include/hyperv/hvgdk_mini.h
> > index 1be7f6a02304..77abddfc750e 100644
> > --- a/include/hyperv/hvgdk_mini.h
> > +++ b/include/hyperv/hvgdk_mini.h
> > @@ -597,8 +597,6 @@ struct ms_hyperv_tsc_page {	 /* HV_REFERENCE_TSC_PAGE */
> >  #define HV_SYNIC_SINT_AUTO_EOI		(1ULL << 17)
> >  #define HV_SYNIC_SINT_VECTOR_MASK	(0xFF)
> >  
> > -#
> > -
> >  /* Hyper-V defined statically assigned SINTs */
> >  #define HV_SYNIC_INTERCEPTION_SINT_INDEX 0x00000000
> >  #define HV_SYNIC_IOMMU_FAULT_SINT_INDEX  0x00000001
> > 
> > base-commit: e3ec97c3abaf2fb68cc755cae3229288696b9f3d
> 
> Reviewed-by: Easwar Hariharan <easwar.hariharan@...ux.microsoft.com>

Applied.