linux-kernel - Re: [PATCH v5 3/7] dt-bindings: auxdisplay: add Titan Micro Electronics TM16xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A137AD5E-2D4E-4C1E-8A71-EF90E60D8F14@gmail.com>
Date: Wed, 01 Oct 2025 22:58:38 -0400
From: Jean-François Lessard <jefflessard3@...il.com>
To: Rob Herring <robh@...nel.org>
CC: Andy Shevchenko <andy@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v5 3/7] dt-bindings: auxdisplay: add Titan Micro Electronics TM16xx

Le 1 octobre 2025 22 h 44 min 31 s HAE, Rob Herring <robh@...nel.org> a écrit :
>On Fri, Sep 26, 2025 at 10:19:04AM -0400, Jean-François Lessard wrote:
>> Add documentation for TM16xx-compatible 7-segment LED display controllers
>> with keyscan.
>> 
...
>> +
>> +  digits:
>> +    type: object
>> +    description: Container for 7-segment digit group definitions
>> +    additionalProperties: false
>> +
>> +    properties:
>> +      "#address-cells":
>> +        const: 1
>> +      "#size-cells":
>> +        const: 0
>> +
>> +    patternProperties:
>> +      "^digit@[0-9]+$":
>
>Unit addresses are typically hex, so: [0-9a-f]+
>

Acknowledged. Will change to hex pattern.

>> +        type: object
>> +        unevaluatedProperties: false
>> +
>> +        properties:
>> +          reg:
>> +            description:
>> +              Digit position identifier numbered sequentially left-to-right,
>> +              with reg=0 representing the leftmost digit position as displayed
>> +              to the user.
>> +            maxItems: 1
>> +
>> +          segments:
>> +            $ref: /schemas/types.yaml#/definitions/uint32-matrix
>> +            description: |
>> +              Array of grid/segment coordinate pairs for each 7-segment position.
>> +              Each entry is <grid segment> mapping to standard 7-segment positions
>> +              in order: a, b, c, d, e, f, g
>> +
>> +              Standard 7-segment layout:
>> +                 aaa
>> +                f   b
>> +                f   b
>> +                 ggg
>> +                e   c
>> +                e   c
>> +                 ddd
>> +            items:
>> +              items:
>> +                - description: Grid index
>> +                - description: Segment index
>> +            minItems: 7
>> +            maxItems: 7
>> +
>> +        required:
>> +          - reg
>> +          - segments
>> +
>> +  leds:
>> +    type: object
>> +    description: Container for individual LED icon definitions
>> +    additionalProperties: false
>> +
>> +    properties:
>> +      "#address-cells":
>> +        const: 2
>> +      "#size-cells":
>> +        const: 0
>> +
>> +    patternProperties:
>> +      "^led@[0-9]+,[0-9]+$":
>
>Again, hex please.
>

Acknowledged. Will change to hex pattern.

>I assume this is <grid>,<segment>? Please add a description for the 
>node and say that.
>

Yes this is <grid>,<segment>. Will add description.

>> +        type: object
>> +        $ref: /schemas/leds/common.yaml#
>> +        unevaluatedProperties: false
>> +
>> +        properties:
>> +          reg:
>> +            description:
>> +              Grid and segment indices as <grid segment> of this individual LED icon
>> +
>> +        required:
>> +          - reg
>> +
>> +dependencies:
>> +  poll-interval:
>> +    - linux,keymap
>> +  linux,keymap:
>> +    - poll-interval
>> +  autorepeat:
>> +    - linux,keymap
>> +    - poll-interval
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +allOf:
>> +  - $ref: /schemas/leds/common.yaml#
>> +    properties:
>> +      color: false
>> +      function: false
>> +      function-enumerator: false
>> +  - $ref: /schemas/input/input.yaml#
>> +  - $ref: /schemas/input/matrix-keymap.yaml#
>> +  # SPI controllers require 3-wire (combined MISO/MOSI line)
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - fdhisi,fd620
>> +              - fdhisi,fd628
>> +              - princeton,pt6964
>> +              - titanmec,tm1618
>> +              - titanmec,tm1620
>> +              - titanmec,tm1628
>> +              - titanmec,tm1638
>> +              - wxicore,aip1618
>> +              - wxicore,aip1628
>> +    then:
>> +      $ref: /schemas/spi/spi-peripheral-props.yaml#
>> +      properties:
>> +        spi-3wire: true
>
>You can drop properties.
>

The issue is spi-3wire is defined in the child node of spi/spi-controller.yaml,
not in spi-peripheral-props.yaml.

Removing properties did not pass dt validation. Am I missing something?

>> +      required:
>> +        - spi-3wire
>
>With those nits fixed,
>
>Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>

Thank you!