linux-kernel - Re: [PATCH v3 04/11] arm64: dts: qcom: sdm845-lg-common: Add leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7543e21dad1f6b3a5b5ab8af74c09415c3d8aff4@postmarketos.org>
Date: Thu, 02 Oct 2025 05:13:34 +0000
From: "Paul Sajna" <sajattack@...tmarketos.org>
To: "Konrad Dybcio" <konrad.dybcio@....qualcomm.com>, "Bjorn Andersson"
 <andersson@...nel.org>, "Konrad Dybcio" <konradybcio@...nel.org>, "Rob
 Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>, "David Heidelberg" <david@...t.cz>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org, "Amir Dahan"
 <system64fumo@...tonmail.com>, "Christopher Brown"
 <crispybrown@...il.com>
Subject: Re: [PATCH v3 04/11] arm64: dts: qcom: sdm845-lg-common: Add leds

October 1, 2025 at 9:01 AM, "Konrad Dybcio" <konrad.dybcio@....qualcomm.com mailto:konrad.dybcio@....qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:


> 
> On 9/29/25 7:05 AM, Paul Sajna wrote:
> 
> > 
> > From: Amir Dahan <system64fumo@...tonmail.com>
> >  
> >  Add the multicolor status led in the phone's notch
> >  
> >  Signed-off-by: Amir Dahan <system64fumo@...tonmail.com>
> >  Signed-off-by: Paul Sajna <sajattack@...tmarketos.org>
> >  ---
> >  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 28 ++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >  
> >  diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> >  index 4c631df56f262ba9e730f6720abd94d374b14692..2a612922ecf7ce3f8a0734cb1a31a8a81efdb4f2 100644
> >  --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> >  +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> >  @@ -6,6 +6,7 @@
> >  */
> >  
> >  #include <dt-bindings/gpio/gpio.h>
> >  +#include <dt-bindings/leds/common.h>
> >  #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> >  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >  
> >  @@ -504,6 +505,33 @@ &pm8998_resin {
> >  status = "okay";
> >  };
> >  
> >  +&pmi8998_lpg {
> >  + status = "okay";
> > 
> Could you read back register 0xd000+0x45 (LED_SRC_SEL) on downstream
> and make sure the value matches upstream?
> 
> A msm8998 kernel fork I have laying around on my computer always seems
> to write '1' in there (which it claims corresponds to VPH_PWR as input)
> 
> Konrad
>

I need more explanation on how to do this please.