linux-kernel - Re: [PATCH] ufs: core: Initialize a variable mode for PA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9fda4a263951753ca7c8d90b454f00f6815b64c6.camel@mediatek.com>
Date: Thu, 2 Oct 2025 08:00:21 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"wkon.kim@...sung.com" <wkon.kim@...sung.com>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>
Subject: Re: [PATCH] ufs: core: Initialize a variable mode for PA_PWRMODE

On Thu, 2025-10-02 at 16:00 +0900, Wonkon Kim wrote:
> 
> If ufshcd_dme_get() fails uic cmd error,
> a variable mode has a garbage value.
> It may return unintended result for pwr mode restore.
> 
> Initialize it as 0 and will return true when ufshcd_dme_get() fails,
> because PA power mode 0 is not defined.
> 
> Signed-off-by: Wonkon Kim <wkon.kim@...sung.com>
> ---
>  drivers/ufs/core/ufshcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 9a43102b2b21..a4438a3cb73a 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6581,7 +6581,7 @@ static inline void
> ufshcd_recover_pm_error(struct ufs_hba *hba)
>  static bool ufshcd_is_pwr_mode_restore_needed(struct ufs_hba *hba)
>  {
>         struct ufs_pa_layer_attr *pwr_info = &hba->pwr_info;
> -       u32 mode;
> +       u32 mode = 0;
> 
>         ufshcd_dme_get(hba, UIC_ARG_MIB(PA_PWRMODE), &mode);
> 
> --
> 2.34.1
> 

Reviewed-by: Peter Wang <peter.wang@...iatek.com>