linux-kernel - Re: [PATCH] clk: COMMON_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251002-rubbing-nucleus-b353e09be786@spud>
Date: Thu, 2 Oct 2025 10:36:01 +0100
From: Conor Dooley <conor@...nel.org>
To: Paul Walmsley <pjw@...nel.org>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>,
	Rahul Pathak <rpathak@...tanamicro.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Anup Patel <apatel@...tanamicro.com>, linux-clk@...r.kernel.org,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: COMMON_CLK_RPMI should depend on RISCV

On Wed, Oct 01, 2025 at 07:15:56PM -0600, Paul Walmsley wrote:
> On Tue, 30 Sep 2025, Geert Uytterhoeven wrote:
> 
> > The RISC-V platform management interface (RPMI) is only available on
> > RISC-V platforms.  Hence add a dependency on RISCV, to prevent asking
> > the user about this driver when configuring a kernel for a different
> > architecture.
> > 
> > Fixes: 5ba9f520f41a33c9 ("clk: Add clock driver for the RISC-V RPMI clock service group")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Thanks Geert for catching this.
> 
> This patch is against unmerged patches in -next.  So I'll plan to add this 
> to the PR that I plan to send to Linus tomorrow -- unless any of the 
> drivers/clk maintainers would prefer that I not.
> 
> > And perhaps the "default RISCV" should be dropped, too?
> 
> Probably.  I guess we should just add this to the arch/riscv defconfig 
> instead.  Let's wait on this one for a few days to see if anyone has any 
> comments, and consider that change for v6.18-rc fixes.

There's little point having "default RISCV" if it's only available on
RISCV in the first place, may as well just be "default y" and be
simpler.

My 2c is that putting it in defconfig is barely worth doing, unless there
are actual platforms that use it.
Does QEMU provide a useful test for it that exercises the various code
paths, that would make it worthwhile to have in defconfig Anup?

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)