linux-kernel - Re: [PATCH v2 08/20] verification/dot2c: Remove superfluous enum assignment and add last comma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <873481skt0.fsf@yellow.woof>
Date: Thu, 02 Oct 2025 11:40:59 +0200
From: Nam Cao <namcao@...utronix.de>
To: Gabriele Monaco <gmonaco@...hat.com>, linux-kernel@...r.kernel.org,
 Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, linux-trace-kernel@...r.kernel.org
Cc: Gabriele Monaco <gmonaco@...hat.com>, Tomas Glozar <tglozar@...hat.com>,
 Juri Lelli <jlelli@...hat.com>, Clark Williams <williams@...hat.com>, John
 Kacur <jkacur@...hat.com>
Subject: Re: [PATCH v2 08/20] verification/dot2c: Remove superfluous enum
 assignment and add last comma

Gabriele Monaco <gmonaco@...hat.com> writes:

> The header files generated by dot2c currently create enums for states
> and events assigning the first element to 0. This is superfluous as it
> happens automatically if no value is specified.
> Also it doesn't add a comma to the last enum elements, which slightly
> complicates the diff if states or events are added.
>
> Remove the assignment to 0 and add a comma to last elements, this
> simplifies the logic for the code generator.
>
> Signed-off-by: Gabriele Monaco <gmonaco@...hat.com>

There are some minor changes which are not mentioned, but not a big deal:

Reviewed-by: Nam Cao <namcao@...utronix.de>