linux-kernel - Re: [PATCH] tracing: fprobe: Fix to init fprobe_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3Yvxs_Z6a1-EPziz79SBRsYHcaOH-CtvUhngYy3bJ71iA@mail.gmail.com>
Date: Thu, 2 Oct 2025 18:00:24 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Steven Rostedt <rostedt@...dmis.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	oliver.sang@...el.com
Subject: Re: [PATCH] tracing: fprobe: Fix to init fprobe_ip_table earlier

On Thu, Oct 2, 2025 at 4:39 PM Masami Hiramatsu (Google)
<mhiramat@...nel.org> wrote:
>
> From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
>
> Since the fprobe_ip_table is used from module unloading in
> the failure path of load_module(), it must be initialized in
> the earlier timing than late_initcall(). Unless that, the
> fprobe_module_callback() will use an uninitialized spinlock of
> fprobe_ip_table.
>
> Initialize fprobe_ip_table in core_initcall which is the same
> timing as ftrace.
>
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202509301440.be4b3631-lkp@intel.com

Don't we need a Fixes tag here?

The other part of this patch is LGTM.

Reviewed-by: Menglong Dong <menglong8.dong@...il.com>

Thanks!
Menglong Dong

> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> ---
>  kernel/trace/fprobe.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/fprobe.c b/kernel/trace/fprobe.c
> index 95e43814b85b..99d83c08b9e2 100644
> --- a/kernel/trace/fprobe.c
> +++ b/kernel/trace/fprobe.c
> @@ -847,4 +847,4 @@ static int __init fprobe_initcall(void)
>         rhltable_init(&fprobe_ip_table, &fprobe_rht_params);
>         return 0;
>  }
> -late_initcall(fprobe_initcall);
> +core_initcall(fprobe_initcall);
>