linux-kernel - RE: [PATCH v3 2/2] usb: ehci: Add Aspeed AST2700 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <KUZSPRMB000536A7B10DA3052340556AF2E7A@KUZSPRMB0005.apcprd06.prod.outlook.com>
Date: Thu, 2 Oct 2025 00:59:07 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Alan Stern <stern@...land.harvard.edu>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 2/2] usb: ehci: Add Aspeed AST2700 support

> Subject: Re: [PATCH v3 2/2] usb: ehci: Add Aspeed AST2700 support
> 
> On Mon, Sep 29, 2025 at 05:56:13AM +0000, Ryan Chen wrote:
> > > > @@ -253,8 +256,13 @@ static int ehci_platform_probe(struct
> > > platform_device *dev)
> > > >  	if (!pdata)
> > > >  		pdata = &ehci_platform_defaults;
> > > >
> > > > +	dma_mask_64 = pdata->dma_mask_64;
> > > > +	match = of_match_device(dev->dev.driver->of_match_table,
> > > > +&dev->dev);
> > >
> > > (I just noticed this.)  The "dev->dev.driver->of_match_table" part looks
> odd.
> > > Why not just write "vt8500_ehci_ids"?  Do you expect that this could
> > > ever have a different value?
> > >
> > > Alan Stern
> > Thanks your feedback.
> > I used dev->dev.driver->of_match_table rather than hard-coding
> > vt8500_ehci_ids to keep the probe code generic and tied to the driver model,
> not to a specific symbol.
> > Functionally it's the same here, but this pattern avoids coupling the
> > probe to a particular table name.
> >
> > How you think ?
> 
> The code doesn't need to be any more generic than the source file it
> containing it.  This particular probe function will never be called for a
> different driver, or a device that matches an OF table different from
> vt8500_ehci_ids, right?

Understood, I want to keep get from of_match_table.
Appreciate your review. Thank a lot.

> 
> Interestingly, there are two other places in drivers/usb/host/ that call
> of_match_device().  fsl-mph-dr-of.c uses my approach and xhci-plat.c uses
> yours.  The difference is that the xhci-platform probe routine _is_ called by
> other drivers, namely, by xhci-rcar.c.
> 
> I guess it's okay to keep this code as written, even though it's not strictly
> necessary
> 
> Reviewed-by: Alan Stern <stern@...land.harvard.edu>
> 
> Alan Stern