linux-kernel - Re: [PATCH v6 00/16] drm/vkms: Add configfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251002122041.7248d8ff@booty>
Date: Thu, 2 Oct 2025 12:20:41 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: louis.chauvet@...tlin.com, hamohammed.sa@...il.com, simona@...ll.ch,
 melissa.srw@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com,
 sebastian.wick@...hat.com, xaver.hugl@....org, victoria@...tem76.com,
 a.hindborg@...nel.org, leitao@...ian.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 00/16] drm/vkms: Add configfs support

Hello José,

On Mon,  1 Sep 2025 14:25:25 +0200
José Expósito <jose.exposito89@...il.com> wrote:

> Hi everyone,
> 
> This series allow to configure one or more VKMS instances without having
> to reload the driver using configfs.
> 
> The process of configuring a VKMS device is documented in "vkms.rst".
> 
> In addition, I created a CLI tool to easily control VKMS instances from the
> command line: vkmsctl [1].
> 
> The series is structured in 3 blocks:
> 
>   - Patches 1..11: Basic device configuration. For simplicity, I kept the
>     available options as minimal as possible.
> 
>   - Patches 12 and 13: New option to skip the default device creation and to-do
>     cleanup.
> 
>   - Patches 14, 15 and 16: Allow to hot-plug and unplug connectors. This is not
>     part of the minimal set of options, but I included in this series so it can
>     be used as a template/example of how new configurations can be added.
> 
> Finally, the code is thoroughly tested by a collection of IGT tests [2]. The IGT
> series is almost fully reviewed (1 patch is missing) and it is waiting on this
> series to be merged.
> 
> I don't know what is preventing this series to be ACK by a DRM maintainer, but
> please, if there is something missing or that needs to be fixed let me know.
> 
> I CCed the configfs maintainers in case they can give feedback about the design
> of the configfs API or the configfs related code, just in case that is one of
> the complicated points to review by DRM maintainers.
> 
> Best wishes,
> José Expósito

I reviewed the whole series and it looks really good. The step-by-step
approach of patches 1.11 especially made it very easy to follow.

With the doc fixes suggested by Harry you can add my:
Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com