lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251002103537.308717-2-eperezma@redhat.com>
Date: Thu,  2 Oct 2025 12:35:36 +0200
From: Eugenio Pérez <eperezma@...hat.com>
To: mst@...hat.com
Cc: Laurent Vivier <lvivier@...hat.com>,
	Stefano Garzarella <sgarzare@...hat.com>,
	Dragos Tatulea DE <dtatulea@...dia.com>,
	Cindy Lu <lulu@...hat.com>,
	Maxime Coquelin <mcoqueli@...hat.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	Yongji Xie <xieyongji@...edance.com>,
	jasowang@...hat.com,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	linux-kernel@...r.kernel.org,
	Jonah Palmer <jonah.palmer@...cle.com>,
	Si-Wei Liu <si-wei.liu@...cle.com>,
	virtualization@...ts.linux.dev,
	Beñat Gartzia Arruabarrena <bgartzia@...hat.com>
Subject: [RFC 1/2] vduse: support feature provisioning

This patch implements features provisioning for vduse devices.  This
allows the device provisioner to clear the features exposed by the
userland device, so the driver never see them.  The intended use case is
to provision more than one different device with the same feature set,
allowing live migration between them.

The device addition validates the provisioned features to be a subset of
the parent features, as the rest of the backends.

Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
---
 drivers/vdpa/vdpa_user/vduse_dev.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index 6c74282d5721..ef8fc795cfeb 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -121,6 +121,7 @@ struct vduse_dev {
 	bool connected;
 	u64 api_version;
 	u64 device_features;
+	u64 supported_features;
 	u64 driver_features;
 	u32 device_id;
 	u32 vendor_id;
@@ -698,7 +699,7 @@ static u64 vduse_vdpa_get_device_features(struct vdpa_device *vdpa)
 {
 	struct vduse_dev *dev = vdpa_to_vduse(vdpa);
 
-	return dev->device_features;
+	return dev->supported_features;
 }
 
 static int vduse_vdpa_set_driver_features(struct vdpa_device *vdpa, u64 features)
@@ -2256,13 +2257,22 @@ struct vduse_mgmt_dev {
 
 static struct vduse_mgmt_dev *vduse_mgmt;
 
-static int vduse_dev_init_vdpa(struct vduse_dev *dev, const char *name)
+static int vduse_dev_init_vdpa(struct vduse_dev *dev, const char *name,
+			       const struct vdpa_dev_set_config *config)
 {
 	struct vduse_vdpa *vdev;
 
 	if (dev->vdev)
 		return -EEXIST;
 
+	if (config->mask & BIT_ULL(VDPA_ATTR_DEV_FEATURES)) {
+		if (config->device_features & ~dev->device_features)
+			return -EINVAL;
+		dev->supported_features = config->device_features;
+	} else {
+		dev->supported_features = dev->device_features;
+	}
+
 	vdev = vdpa_alloc_device(struct vduse_vdpa, vdpa, dev->dev,
 				 &vduse_vdpa_config_ops, &vduse_map_ops,
 				 dev->ngroups, dev->nas, name, true);
@@ -2289,7 +2299,7 @@ static int vdpa_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
 		mutex_unlock(&vduse_lock);
 		return -EINVAL;
 	}
-	ret = vduse_dev_init_vdpa(dev, name);
+	ret = vduse_dev_init_vdpa(dev, name, config);
 	mutex_unlock(&vduse_lock);
 	if (ret)
 		return ret;
@@ -2376,6 +2386,7 @@ static int vduse_mgmtdev_init(void)
 	vduse_mgmt->mgmt_dev.id_table = id_table;
 	vduse_mgmt->mgmt_dev.ops = &vdpa_dev_mgmtdev_ops;
 	vduse_mgmt->mgmt_dev.device = &vduse_mgmt->dev;
+	vduse_mgmt->mgmt_dev.config_attr_mask = BIT_ULL(VDPA_ATTR_DEV_FEATURES);
 	ret = vdpa_mgmtdev_register(&vduse_mgmt->mgmt_dev);
 	if (ret)
 		device_unregister(&vduse_mgmt->dev);
-- 
2.51.0


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ