[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <338e1456-533b-4b59-a660-00d0ca51aada@arm.com>
Date: Thu, 2 Oct 2025 13:17:57 +0100
From: Robin Murphy <robin.murphy@....com>
To: Johan Hovold <johan@...nel.org>, Joerg Roedel <joro@...tes.org>,
Will Deacon <will@...nel.org>
Cc: Sven Peter <sven@...nel.org>, Janne Grunau <j@...nau.net>,
Rob Clark <robin.clark@....qualcomm.com>,
Marek Szyprowski <m.szyprowski@...sung.com>, Yong Wu <yong.wu@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Chen-Yu Tsai <wens@...e.org>, Thierry Reding <thierry.reding@...il.com>,
Krishna Reddy <vdumpa@...dia.com>, iommu@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/14] iommu: fix device leaks
On 2025-09-25 1:27 pm, Johan Hovold wrote:
> This series fixes device leaks in the iommu drivers, which pretty
> consistently failed to drop the reference taken by
> of_find_device_by_node() when looking up iommu platform devices.
>
> Included are also a couple of related cleanups.
Modulo the nitpick for OMAP,
Acked-by: Robin Murphy <robin.murphy@....com>
We could in fact also clean up nearly all the NULL checks in these areas
that are now entirely redundant since per-instance ops lookup, but that
might just le;ad to more patches from the static checker brigade trying
to put them back... :/
Thanks,
Robin.
> Johan
>
>
> Johan Hovold (14):
> iommu/apple-dart: fix device leak on of_xlate()
> iommu/qcom: fix device leak on of_xlate()
> iommu/exynos: fix device leak on of_xlate()
> iommu/ipmmu-vmsa: fix device leak on of_xlate()
> iommu/mediatek: fix device leak on of_xlate()
> iommu/mediatek: fix device leaks on probe()
> iommu/mediatek: simplify dt parsing error handling
> iommu/mediatek-v1: fix device leak on probe_device()
> iommu/mediatek-v1: fix device leaks on probe()
> iommu/mediatek-v1: add missing larb count sanity check
> iommu/omap: fix device leaks on probe_device()
> iommu/omap: simplify probe_device() error handling
> iommu/sun50i: fix device leak on of_xlate()
> iommu/tegra: fix device leak on probe_device()
>
> drivers/iommu/apple-dart.c | 2 ++
> drivers/iommu/arm/arm-smmu/qcom_iommu.c | 10 +++-----
> drivers/iommu/exynos-iommu.c | 9 +++----
> drivers/iommu/ipmmu-vmsa.c | 2 ++
> drivers/iommu/mtk_iommu.c | 33 +++++++++++++++++--------
> drivers/iommu/mtk_iommu_v1.c | 28 +++++++++++++++++----
> drivers/iommu/omap-iommu.c | 32 +++++++++++++++---------
> drivers/iommu/sun50i-iommu.c | 2 ++
> drivers/iommu/tegra-smmu.c | 5 ++--
> 9 files changed, 81 insertions(+), 42 deletions(-)
>
Powered by blists - more mailing lists