linux-kernel - Re: [RFC PATCH v3 01/24] sched/deadline: Do not access dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aN55xzzO-LplRvIp@jlelli-thinkpadt14gen4.remote.csb>
Date: Thu, 2 Oct 2025 14:10:31 +0100
From: Juri Lelli <juri.lelli@...hat.com>
To: Yuri Andriaccio <yurand2000@...il.com>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	linux-kernel@...r.kernel.org,
	Luca Abeni <luca.abeni@...tannapisa.it>,
	Yuri Andriaccio <yuri.andriaccio@...tannapisa.it>
Subject: Re: [RFC PATCH v3 01/24] sched/deadline: Do not access dl_se->rq
 directly

Hello,

On 29/09/25 11:21, Yuri Andriaccio wrote:
> From: luca abeni <luca.abeni@...tannapisa.it>
> 
> Make deadline.c code access the runqueue of a scheduling entity saved in the
> sched_dl_entity data structure. This allows future patches to save different
> runqueues in sched_dl_entity other than the global runqueues.
> 
> Signed-off-by: luca abeni <luca.abeni@...tannapisa.it>
> Signed-off-by: Yuri Andriaccio <yurand2000@...il.com>
> ---
>  kernel/sched/deadline.c | 27 ++++++++++++++-------------

Nit, I believe there are a couple of dl_se->rq direct usages in fair.c
left after this change. The are outside deadline and they are indeed
modified anyway by next patch. Just for your consideration in case you
want to do something about them from completeness.

...

> @@ -1651,9 +1652,9 @@ void sched_init_dl_servers(void)
>  
>  		WARN_ON(dl_server(dl_se));
>  
> -		dl_server_apply_params(dl_se, runtime, period, 1);
> -
>  		dl_se->dl_server = 1;
> +		WARN_ON(dl_server_apply_params(dl_se, runtime, period, 1));
> +

The move after dl_server is initialized is indeed needed, but maybe we
should mention the small functional change (also the additon of WARN) in
the changelog.

Best,
Juri