linux-kernel - Re: [PATCH v2 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7a1de5c459a98935ad6f2fbdc35e1e96d1242ba.camel@iokpp.de>
Date: Thu, 02 Oct 2025 15:19:33 +0200
From: Bean Huo <beanhuo@...pp.de>
To: Avri Altman <Avri.Altman@...disk.com>, "avri.altman@....com"
 <avri.altman@....com>, "bvanassche@....org" <bvanassche@....org>, 
 "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>, "jejb@...ux.ibm.com"
 <jejb@...ux.ibm.com>,  "martin.petersen@...cle.com"
 <martin.petersen@...cle.com>, "can.guo@....qualcomm.com"
 <can.guo@....qualcomm.com>, "ulf.hansson@...aro.org"
 <ulf.hansson@...aro.org>,  "beanhuo@...ron.com" <beanhuo@...ron.com>,
 "jens.wiklander@...aro.org" <jens.wiklander@...aro.org>
Cc: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver
 for UFS devices

On Wed, 2025-10-01 at 10:06 +0000, Avri Altman wrote:
> > From: Bean Huo <beanhuo@...ron.com>
> > 
> > This patch adds OP-TEE based RPMB support for UFS devices. This enables
> > secure RPMB operations on UFS devices through OP-TEE, providing the same
> > functionality available for eMMC devices and extending kernel-based secure
> > storage support to UFS-based systems.
> > 
> > Benefits of OP-TEE based RPMB implementation:
> > - Eliminates dependency on userspace supplicant for RPMB access
> > - Enables early boot secure storage access (e.g., fTPM, secure UEFI
> > variables)
> > - Provides kernel-level RPMB access as soon as UFS driver is initialized
> > - Removes complex initramfs dependencies and boot ordering requirements
> > - Ensures reliable and deterministic secure storage operations
> > - Supports both built-in and modular fTPM configurations
> > 
> > Co-developed-by: Can Guo <can.guo@....qualcomm.com>
> > Signed-off-by: Can Guo <can.guo@....qualcomm.com>
> > Signed-off-by: Bean Huo <beanhuo@...ron.com>
> Reviewed-by: Avri Altman <avri.altman@...disk.com>
> 
> Nit: Would it make sense to simplify things, e.g. :
> Instead of struct list_head rpmbs;
> Use:
> struct ufs_rpmb_dev *rpmbs[4];

Avri, 

yes, having a fixed-size data set, choose an array over a list when needs fast,
random access to elements by index. I will address it in next version.

> Also, I don't remember if you were planning to add the additional rpmb
> operations (6 to 9) later or not.

yes, to make those usable, firstly need to enable in op-tee OS,  I will check
op-tee OS and enable in extension patch.

Kind regards,
Bean

> 
> Thanks,
> Avri