[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aN6IR811AtfIUsWS@jlelli-thinkpadt14gen4.remote.csb>
Date: Thu, 2 Oct 2025 15:12:23 +0100
From: Juri Lelli <juri.lelli@...hat.com>
To: Yuri Andriaccio <yurand2000@...il.com>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Valentin Schneider <vschneid@...hat.com>,
linux-kernel@...r.kernel.org,
Luca Abeni <luca.abeni@...tannapisa.it>,
Yuri Andriaccio <yuri.andriaccio@...tannapisa.it>
Subject: Re: [RFC PATCH v3 04/24] sched/rt: Move some functions from rt.c to
sched.h
Hello,
On 29/09/25 11:22, Yuri Andriaccio wrote:
> From: luca abeni <luca.abeni@...tannapisa.it>
>
> Make the following functions be non-static and move them in sched.h, so that
> they can be used also in other source files:
> - rt_task_of()
> - rq_of_rt_rq()
> - rt_rq_of_se()
> - rq_of_rt_se()
>
> There are no functional changes. This is needed by future patches.
>
> Signed-off-by: luca abeni <luca.abeni@...tannapisa.it>
> Signed-off-by: Yuri Andriaccio <yurand2000@...il.com>
> ---
> kernel/sched/rt.c | 52 ------------------------------------------
> kernel/sched/sched.h | 54 ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+), 52 deletions(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index a7d063d2303..a599f63bf7f 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -168,34 +168,6 @@ static void destroy_rt_bandwidth(struct rt_bandwidth *rt_b)
>
> #define rt_entity_is_task(rt_se) (!(rt_se)->my_q)
Do we want to move this macro as well, so that rt_task_of() doesn't need
to change?
> -static inline struct task_struct *rt_task_of(struct sched_rt_entity *rt_se)
> -{
> - WARN_ON_ONCE(!rt_entity_is_task(rt_se));
> -
> - return container_of(rt_se, struct task_struct, rt);
> -}
...
> +#ifdef CONFIG_RT_GROUP_SCHED
> +static inline struct task_struct *rt_task_of(struct sched_rt_entity *rt_se)
> +{
> + WARN_ON_ONCE(rt_se->my_q);
> +
> + return container_of(rt_se, struct task_struct, rt);
> +}
Thanks,
Juri
Powered by blists - more mailing lists