linux-kernel - [PATCH v2 00/15] serial: sc16is7xx: register access fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251002145738.3250272-1-hugo@hugovil.com>
Date: Thu,  2 Oct 2025 10:57:23 -0400
From: Hugo Villeneuve <hugo@...ovil.com>
To: gregkh@...uxfoundation.org,
	jirislaby@...nel.org,
	fvallee@...rea.fr
Cc: linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org,
	hugo@...ovil.com,
	Hugo Villeneuve <hvilleneuve@...onoff.com>
Subject: [PATCH v2 00/15] serial: sc16is7xx: register access fixes and improvements

From: Hugo Villeneuve <hvilleneuve@...onoff.com>

Hello,
this patch series brings some fixes and improvements to the register
accesses for the sc16is7xx driver.

It also adds some minor improvements, and cleanups to uniformize code
style accross the driver.

I have tested the changes on a custom board with two SC16IS752 DUART over
a SPI interface using a Variscite IMX8MN NANO SOM. The four UARTs are
configured in RS-485 mode.

I did not test the change on a SC16is7xx using I2C interface, as my custom
board is only using SPI.

Thank you.

Link: [v1] https://lore.kernel.org/linux-serial/20250924153740.806444-1-hugo@hugovil.com/raw

Changes for V2:
- Patch "change incorrect indentation": move to same line and reword (suggested
  by Maarten Brock)
- remove superfluous rc variable (suggested by Jiri Slaby)
- replace guard with scoped_guard() in sc16is7xx_ms_proc()
  (suggested by Jiri Slaby)
- Patch "use dev_err_probe() instead of dev_err()": remove original dev_err()
  line and reword (suggested by Jiri Slaby)
- Patch "remove empty line": remove useless cast and reorder variables
  for reverse xmas tree (suggested by Jiri Slaby)
- Simplify to_sc16is7xx_one() macro
- Reformat some multi-line comments up to 100 columns (suggested by Jiri Slaby)
- Remove typo cleanup from patch "add/improve comments" and move to patch
  "reformat comments to improve readability"

Hugo Villeneuve (15):
  serial: sc16is7xx: remove useless enable of enhanced features
  serial: sc16is7xx: rename LCR macros to better reflect usage
  serial: sc16is7xx: rename EFR mutex with generic name
  serial: sc16is7xx: define common register access function
  serial: sc16is7xx: remove unnecessary pointer cast
  serial: sc16is7xx: use guards for simple mutex locks
  serial: sc16is7xx: drop -ENOMEM error message
  serial: sc16is7xx: declare SPR/TLR/XOFF2 register as volatile
  serial: sc16is7xx: move port/channel init to separate function
  serial: sc16is7xx: simplify to_sc16is7xx_one() with a single parameter
  serial: sc16is7xx: Kconfig: allow building with COMPILE_TEST
  serial: sc16is7xx: use KBUILD_MODNAME
  serial: sc16is7xx: change conditional operator indentation
  serial: sc16is7xx: reformat comments to improve readability
  serial: sc16is7xx: add comments for lock requirements

 drivers/tty/serial/Kconfig         |   2 +-
 drivers/tty/serial/sc16is7xx.c     | 420 +++++++++++++----------------
 drivers/tty/serial/sc16is7xx.h     |   1 -
 drivers/tty/serial/sc16is7xx_i2c.c |   4 +-
 drivers/tty/serial/sc16is7xx_spi.c |   4 +-
 5 files changed, 187 insertions(+), 244 deletions(-)


base-commit: f4abab350840d58d69814c6993736f03ac27df83
-- 
2.39.5