linux-kernel - Re: [PATCH 1/1] tools build: Don't assume libtracefs-devel is always available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fUfBzUTOJG7t7nwvZkcf+LKVakGnNqgVLSW8CjsLxFkDw@mail.gmail.com>
Date: Thu, 2 Oct 2025 08:21:08 -0700
From: Ian Rogers <irogers@...gle.com>
To: Tomas Glozar <tglozar@...hat.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Gabriele Monaco <gmonaco@...hat.com>, 
	James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>, 
	Kan Liang <kan.liang@...ux.intel.com>, Steven Rostedt <rostedt@...dmis.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1] tools build: Don't assume libtracefs-devel is always available

On Thu, Oct 2, 2025 at 7:13 AM Tomas Glozar <tglozar@...hat.com> wrote:
>
> čt 2. 10. 2025 v 15:05 odesílatel Arnaldo Carvalho de Melo
> <acme@...nel.org> napsal:
> >
> > perf doesn't use libtracefs and so it doesn't make sense to assume it is
> > always available when building test-all.bin, defeating the feature check
> > speedup it provides.
> >
> > The other tools/build/ users such as rtla, rv, etc call $(feature_check
> > libtracefs) to check its availability instead of using the test-all.bin
> > mechanism, stopping the build and asking for libtracefs-devel to be
> > installed.
> >
> > Noticed after applying Ian Roger's removal unused libtracefs
> > configuration in tools/perf/.
> >
> > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > Cc: Gabriele Monaco <gmonaco@...hat.com>
> > Cc: Ian Rogers <irogers@...gle.com>
> > Cc: James Clark <james.clark@...aro.org>
> > Cc: Jiri Olsa <jolsa@...nel.org>
> > Cc: Kan Liang <kan.liang@...ux.intel.com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Cc: Tomas Glozar <tglozar@...hat.com>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
>
> Acked-by: Tomas Glozar <tglozar@...hat.com>
>
> Perhaps it would also make sense to clarify in a comment that
> test-all.c is to speed up perf build rather than rv, rtla etc. (which
> don't use most of the dependencies listed there)?

There's a big comment in Makefile.feature:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/build/Makefile.feature#n24
I think that FEATURE_TESTS_BASIC tests are covered by test-all.c so I
think this change needs to remove libtracefs from FEATURE_TESTS_BASIC
otherwise  $(feature-libtracefs) will evaluate to 1 even though no
libtracefs testing has been performed. We can't just remove the
tracefs feature test as there are dependencies in rv, rtla, etc.

Thanks,
Ian