linux-kernel - Re: [PATCH] cxl/hdm: allow zero sized committed decoders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02a4b5f1-ad29-4825-9040-ff96e328f674@intel.com>
Date: Thu, 2 Oct 2025 08:32:35 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Gregory Price <gourry@...rry.net>, Vishal Aslot <vaslot@...dia.com>
Cc: Davidlohr Bueso <dave@...olabs.net>,
 Jonathan Cameron <jonathan.cameron@...wei.com>,
 Alison Schofield <alison.schofield@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Dan Williams <dan.j.williams@...el.com>, Li Ming <ming.li@...omail.com>,
 Peter Zijlstra <peterz@...radead.org>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 Zijun Hu <zijun.hu@....qualcomm.com>,
 "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl/hdm: allow zero sized committed decoders



On 10/1/25 10:48 PM, Gregory Price wrote:
> On Wed, Oct 01, 2025 at 08:37:26PM +0000, Vishal Aslot wrote:
>> @@ -1210,6 +1210,11 @@ int devm_cxl_enumerate_decoders(struct cxl_hdm *cxlhdm,
>>                 rc = init_hdm_decoder(port, cxld, target_map, hdm, i,
>>                                       &dpa_base, info);
>>                 if (rc) {
>> +                       if (rc == -ENOSPC) {
>> +                               put_device(&cxld->dev);
>> +                               rc = 0;
>> +                               continue;
>> +                       }
> 
> How do you suggest actually testing this? I briefly poked at this in
> QEMU trying to commit decoders, but i found myself incapable of
> exercising this path.

It may be worthwhile adding a cxl_test test case for this.

> 
>>                         dev_warn(&port->dev,
>>                                  "Failed to initialize decoder%d.%d\n",
>>                                  port->id, i);
>> --
>> 2.34.1