linux-kernel - Re: [PATCH v2] media: synopsys: hdmirx: Detect broken interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169cf964-85a7-4f96-9a0c-0f06c7bfa012@collabora.com>
Date: Thu, 2 Oct 2025 18:50:41 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
 Hans Verkuil <hverkuil@...all.nl>, jose.abreu@...opsys.com,
 nelson.costa@...opsys.com, shawn.wen@...k-chips.com,
 nicolas.dufresne@...labora.com, kernel@...labora.com,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2] media: synopsys: hdmirx: Detect broken interrupt

On 10/2/25 18:33, Sebastian Reichel wrote:
> Hello Dmitry,
> 
> On Thu, Oct 02, 2025 at 05:07:50PM +0300, Dmitry Osipenko wrote:
>> Downstream version of RK3588 U-Boot uses customized TF-A that remaps
>> HDMIRX hardware interrupt, routing it via firmware that isn't supported
>> by upstream driver.
>>
>> Detect broken interrupt and print a clarifying error message about a need
>> to use open-source TF-A with this driver.
>>
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
>> ---
>> Changelog:
>>
>> v2: - Added PHY r/w lock and moved the clarifying error message as
>>       was suggested by Sebastian Reichel.
>>
>>  .../platform/synopsys/hdmirx/snps_hdmirx.c    | 90 ++++++++++++++++++-
>>  .../platform/synopsys/hdmirx/snps_hdmirx.h    |  2 +
>>  2 files changed, 90 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> index b7d278b3889f..e6456352dfa5 100644
>> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> 
> #include <linux/cleanup.h>
> 
> Otherwise LGTM and hopefully helps people to figure out the root
> cause of their problems:
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Thanks for the review. The cleanup.h always included by mutex/spinlock
headers, there is no need to include it explicitly.


-- 
Best regards,
Dmitry