linux-kernel - Re: [PATCH 2/3] PCI/IDE: Add Address Association Register setup for RP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68dea12c352c0_1fa210071@dwillia2-mobl4.notmuch>
Date: Thu, 2 Oct 2025 08:58:36 -0700
From: <dan.j.williams@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	<dan.j.williams@...el.com>
CC: Xu Yilun <yilun.xu@...ux.intel.com>, <linux-coco@...ts.linux.dev>,
	<linux-pci@...r.kernel.org>, <yilun.xu@...el.com>,
	<baolu.lu@...ux.intel.com>, <zhenzhong.duan@...el.com>,
	<aneesh.kumar@...nel.org>, <bhelgaas@...gle.com>, <aik@....com>, LKML
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] PCI/IDE: Add Address Association Register setup for
 RP

Ilpo Järvinen wrote:
[..]
> > > @@ -206,6 +210,24 @@ struct pci_ide *pci_ide_stream_alloc(struct pci_dev *pdev)
> > >  	else
> > >  		rid_end = pci_dev_id(pdev);
> > >  
> > > +	br = pci_upstream_bridge(pdev);
> > > +	if (!br)
> > > +		return NULL;
> > > +
> > > +	res = &br->resource[PCI_BRIDGE_MEM_WINDOW];
> > > +	if (res->flags & IORESOURCE_MEM) {
> > 
> > Per Ilpo this can now just be a size check.
> 
> I don't know why you said this about size as you implemented it below 
> correctly using res->parent check (inside resource_assigned()).

Oh, stale comment. I wrote this, then read your suggestion about
resource_assigned(), updated the proposed patch, but failed to come back
and adjust this stale comment.

Sorry for the confusion.