linux-kernel - Re: [PATCH] s390/uv: Fix the comment of the uv_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251002182456.273e7205@p-imbrenda>
Date: Thu, 2 Oct 2025 18:24:56 +0200
From: Claudio Imbrenda <imbrenda@...ux.ibm.com>
To: Thomas Huth <thuth@...hat.com>
Cc: freude@...ux.ibm.com, Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        David Hildenbrand
 <david@...hat.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Sven Schnelle
 <svens@...ux.ibm.com>, kvm@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/uv: Fix the comment of the uv_find_secret()
 function

On Thu,  2 Oct 2025 17:54:23 +0200
Thomas Huth <thuth@...hat.com> wrote:

> From: Thomas Huth <thuth@...hat.com>
> 
> The uv_get_secret_metadata() function has been removed some
> months ago, so we should not mention it in the comment anymore.
> 
> Fixes: a42831f0b74dc ("s390/uv: Remove uv_get_secret_metadata function")
> Signed-off-by: Thomas Huth <thuth@...hat.com>

Acked-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>

> ---
>  arch/s390/kernel/uv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index 47f574cd1728a..324cd549807a5 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -866,8 +866,8 @@ static int find_secret_in_page(const u8 secret_id[UV_SECRET_ID_LEN],
>  	return -ENOENT;
>  }
>  
> -/*
> - * Do the actual search for `uv_get_secret_metadata`.
> +/**
> + * uv_find_secret() - search secret metadata for a given secret id.
>   * @secret_id: search pattern.
>   * @list: ephemeral buffer space
>   * @secret: output data, containing the secret's metadata.