linux-kernel - [PATCH] ccp/hsti: Fix bogus sizeof in psp_populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <5743ec02c374ce52d1b406d41e9e240d049ee7e2.1759427927.git.teddy.astie@vates.tech>
Date: Thu, 02 Oct 2025 18:04:15 +0000
From: "Teddy Astie" <teddy.astie@...es.tech>
To: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Cc: "Teddy Astie" <teddy.astie@...es.tech>, "Mario Limonciello" <mario.limonciello@....com>, "Tom Lendacky" <thomas.lendacky@....com>, "John Allen" <john.allen@....com>, "Herbert Xu" <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>
Subject: [PATCH] ccp/hsti: Fix bogus sizeof in psp_populate_hsti

Payload is actually struct hsti_request and not a pointer which
makes the considered payload size smaller than it should be.

Signed-off-by: Teddy Astie <teddy.astie@...es.tech>
Fixes: 82f9327f774c ("crypto: ccp - Add support for getting security attributes on some older systems")
---
CC: Mario Limonciello <mario.limonciello@....com>
CC: Tom Lendacky <thomas.lendacky@....com>
CC: John Allen <john.allen@....com>
CC: Herbert Xu <herbert@...dor.apana.org.au>
CC: "David S. Miller" <davem@...emloft.net>
---
 drivers/crypto/ccp/hsti.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/ccp/hsti.c b/drivers/crypto/ccp/hsti.c
index 1b39a4fb55c0..0e6b73b55dbf 100644
--- a/drivers/crypto/ccp/hsti.c
+++ b/drivers/crypto/ccp/hsti.c
@@ -88,7 +88,7 @@ static int psp_poulate_hsti(struct psp_device *psp)
 	if (!req)
 		return -ENOMEM;

-	req->header.payload_size = sizeof(req);
+	req->header.payload_size = sizeof(*req);

 	ret = psp_send_platform_access_msg(PSP_CMD_HSTI_QUERY, (struct psp_request *)req);
 	if (ret)
-- 
2.51.0

--
 | Vates

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech