linux-kernel - Re: [PATCH v1] perf test: Stat std output don't fail metric only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aN6_FKWEfYLmUhw0@x1>
Date: Thu, 2 Oct 2025 15:06:12 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Veronika Molnarova <vmolnaro@...hat.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf test: Stat std output don't fail metric only

On Sun, Sep 14, 2025 at 11:21:40AM -0700, Ian Rogers wrote:
> When running on a hypervisor the expected IPC metric may be missing as
> the events may fail to be read. Don't expect metric output for this
> test to avoid it failing.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/tests/shell/stat+std_output.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/shell/stat+std_output.sh b/tools/perf/tests/shell/stat+std_output.sh
> index 6fee67693ba7..ec41f24299d9 100755
> --- a/tools/perf/tests/shell/stat+std_output.sh
> +++ b/tools/perf/tests/shell/stat+std_output.sh
> @@ -90,7 +90,11 @@ function commachecker()
>  		}
>  	done < "${stat_output}"
>  
> -	[ $metric_only -eq 1 ] && exit 1
> +	if [ $metric_only -ne 1 ]
> +	then
> +		echo "Missing metric only output in:"
> +		cat "${stat_output}"
> +	fi
>  	return 0
>  }
>  
> -- 
> 2.51.0.384.g4c02a37b29-goog
>