[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aN9Q7BxpPOSYBVU5@gourry-fedora-PF4VCD3F>
Date: Fri, 3 Oct 2025 00:28:28 -0400
From: Gregory Price <gourry@...rry.net>
To: Vishal Aslot <vaslot@...dia.com>
Cc: Dave Jiang <dave.jiang@...el.com>, Davidlohr Bueso <dave@...olabs.net>,
Jonathan Cameron <jonathan.cameron@...wei.com>,
Alison Schofield <alison.schofield@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>,
Ira Weiny <ira.weiny@...el.com>,
Dan Williams <dan.j.williams@...el.com>,
Li Ming <ming.li@...omail.com>,
Peter Zijlstra <peterz@...radead.org>,
Dan Carpenter <dan.carpenter@...aro.org>,
Zijun Hu <zijun.hu@....qualcomm.com>,
"linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] cxl/hdm: allow zero sized committed decoders
On Fri, Oct 03, 2025 at 12:59:07AM +0000, Vishal Aslot wrote:
>
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index e9e1d555cec6..50164fd1b434 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -1047,10 +1047,10 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
> }
>
> + port->commit_end = cxld->id;
> +
Went looking to understand what commit_end actually does here, can you
help explain?
> if (size == 0) {
> - dev_warn(&port->dev,
> + dev_dbg(&port->dev,
> "decoder%d.%d: Committed with zero size\n",
> port->id, cxld->id);
> - return -ENXIO;
> + return -ENOSPC;
> }
> - port->commit_end = cxld->id;
> } else {
> @@ -1210,6 +1210,9 @@ int devm_cxl_enumerate_decoders(struct cxl_hdm *cxlhdm,
> rc = init_hdm_decoder(port, cxld, target_map, hdm, i,
> &dpa_base, info);
> if (rc) {
> + if (rc == -ENOSPC) {
> + continue;
> + }
Don't need brackets here
> dev_warn(&port->dev,
> "Failed to initialize decoder%d.%d\n",
> port->id, i);
> --
> 2.34.1
Powered by blists - more mailing lists