[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aN9g2YfwZzBjyiOr@google.com>
Date: Fri, 3 Oct 2025 14:36:25 +0900
From: Namhyung Kim <namhyung@...nel.org>
To: Zecheng Li <zecheng@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
Adrian Hunter <adrian.hunter@...el.com>,
"Liang, Kan" <kan.liang@...ux.intel.com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Xu Liu <xliuprof@...gle.com>, linux-perf-users@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 01/10] perf annotate: Skip annotating data types to
lea instructions
Hello,
On Wed, Sep 17, 2025 at 07:57:59PM +0000, Zecheng Li wrote:
> Introduce a helper function is_address_gen_insn() to check
> arch-dependent address generation instructions like lea in x86. Remove
> type annotation on these instructions since they are not accessing
> memory. It should be counted as `no_mem_ops`.
>
> Signed-off-by: Zecheng Li <zecheng@...gle.com>
> ---
> tools/perf/util/annotate.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index c9b220d9f924..e2370b7fd599 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -2699,6 +2699,19 @@ static bool is_stack_canary(struct arch *arch, struct annotated_op_loc *loc)
> return false;
> }
>
> +/**
> + * Returns true if the instruction has a memory operand without
> + * performing a load/store
> + */
> +static bool is_address_gen_insn(struct arch *arch, struct disasm_line *dl)
> +{
> + if (arch__is(arch, "x86"))
Please put parentheses if the inner statement is placed on multiple
lines even if it's a single statement.
Otherwise, looks good to me.
Thanks,
Namhyung
> + if (!strncmp(dl->ins.name, "lea", 3))
> + return true;
> +
> + return false;
> +}
> +
> static struct disasm_line *
> annotation__prev_asm_line(struct annotation *notes, struct disasm_line *curr)
> {
> @@ -2807,6 +2820,12 @@ __hist_entry__get_data_type(struct hist_entry *he, struct arch *arch,
> return &stackop_type;
> }
>
> + if (is_address_gen_insn(arch, dl)) {
> + istat->bad++;
> + ann_data_stat.no_mem_ops++;
> + return NO_TYPE;
> + }
> +
> for_each_insn_op_loc(&loc, i, op_loc) {
> struct data_loc_info dloc = {
> .arch = arch,
> --
> 2.51.0.384.g4c02a37b29-goog
>
Powered by blists - more mailing lists