linux-kernel - Re: [PATCH v2 1/4] NFSD/blocklayout: Fix minlength check in proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aN9zNZ7n4KwhIZrJ@infradead.org>
Date: Thu, 2 Oct 2025 23:54:45 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Sergey Bashirov <sergeybashirov@...il.com>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	Christoph Hellwig <hch@...radead.org>, Dai Ngo <Dai.Ngo@...cle.com>,
	Jeff Layton <jlayton@...nel.org>, NeilBrown <neil@...wn.name>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Tom Talpey <tom@...pey.com>, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] NFSD/blocklayout: Fix minlength check in
 proc_layoutget

On Thu, Oct 02, 2025 at 11:31:11PM +0300, Sergey Bashirov wrote:
> Minor fix as part of the functional changes. The extent returned by

I'd drop the first sentence here.

> the file system may have a smaller offset than the segment offset
> requested by the client. In this case, the minimum segment length
> must be checked against the requested range. Otherwise, the client
> may not be able to continue the read/write operation.
> 
> Signed-off-by: Sergey Bashirov <sergeybashirov@...il.com>

Can you add a Fixes: tag here?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>