linux-kernel - Re: [PATCH v16 0/9] Add PWM support for IPQ chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DS7PR19MB8883BDB4C3147C86F062A4B29DE4A@DS7PR19MB8883.namprd19.prod.outlook.com>
Date: Fri, 3 Oct 2025 13:30:13 +0400
From: George Moussalem <george.moussalem@...look.com>
To: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@....qualcomm.com>,
 Uwe Kleine-König <ukleinek@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Baruch Siach <baruch@...s.co.il>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-pwm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Devi Priya <quic_devipriy@...cinc.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Baruch Siach <baruch.siach@...lu.com>
Subject: Re: [PATCH v16 0/9] Add PWM support for IPQ chipsets

Hi Kathiravan,

On 10/3/25 13:04, Kathiravan Thirumoorthy wrote:
> 
> On 10/1/2025 7:34 PM, George Moussalem via B4 Relay wrote:
>> Add PWM driver and binding support for IPQ chipsets.
>> Also, add nodes to add support for pwm in ipq6018, ipq5018, ipq5332, and
>> ipq9574.
>>
>> I've picked up work based on Devi's last submission (v15) which dates
>> back to 05 October 2023 as below SoCs are still active.
>>
>> V16:
>>
>>    Removed reg description in bindings as the offset is not relative to
>>    the TCSR region anymore since simple-mfd support was dropped and PWM
>>    nodes defined as their own nodes, not child nodes. Updated the example
>>    too.
>>
>>    Dropped patch to add simple-mfd support to the qcom,tcsr bindings
> 
> George, thanks for taking up this series.
> 
> Can you elaborate on why the qcom,tcsr binding change is dropped and 
> made the PWM as an independent node? IIUC, it should be child of TCSR 
> node. In V15, I see the qcom,tcsr binding is applied and *dropped only* 
> due to dependencies / lack of information on the "pwm-cells" property.

Please see below patch where it was decided to drop simple-mfd as TCSR
is configuration only and any child devices should be defined outside of it:
https://lore.kernel.org/all/20220909091056.128949-1-krzysztof.kozlowski@linaro.org/


> 
> Thanks,
> 
> Kathiravan T.
> 

Best regards,
George