linux-kernel - Re: [PATCH] virtio_vdpa: fix misleading return in void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251003070729-mutt-send-email-mst@kernel.org>
Date: Fri, 3 Oct 2025 07:08:01 -0400
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: eperezma@...hat.com, jasowang@...hat.com, xuanzhuo@...ux.alibaba.com,
	virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio_vdpa: fix misleading return in void function

On Wed, Oct 01, 2025 at 12:16:50PM -0700, Alok Tiwari wrote:
> virtio_vdpa_set_status() is declared as returning void, but it used
> "return vdpa_set_status()" Since vdpa_set_status() also returns
> void, the return statement is unnecessary and misleading.
> Remove it.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Fixes: c043b4a8cf3b ("virtio: introduce a vDPA based transport")


> ---
>  drivers/virtio/virtio_vdpa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
> index 657b07a60788..1abecaf76465 100644
> --- a/drivers/virtio/virtio_vdpa.c
> +++ b/drivers/virtio/virtio_vdpa.c
> @@ -80,7 +80,7 @@ static void virtio_vdpa_set_status(struct virtio_device *vdev, u8 status)
>  {
>  	struct vdpa_device *vdpa = vd_get_vdpa(vdev);
>  
> -	return vdpa_set_status(vdpa, status);
> +	vdpa_set_status(vdpa, status);
>  }
>  
>  static void virtio_vdpa_reset(struct virtio_device *vdev)
> -- 
> 2.50.1